From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: [PATCH 3/3] eal: for safety, use snprintf instead of sprintf Date: Tue, 16 Dec 2014 16:30:24 +0000 Message-ID: <1418747424-22254-4-git-send-email-bruce.richardson@intel.com> References: <1418747424-22254-1-git-send-email-bruce.richardson@intel.com> To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1418747424-22254-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" When printing the version string to a local variable, use snprintf for safety over sprintf. This is general good practice even if the values to print are all hard-coded. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/include/rte_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_version.h b/lib/librte_eal/common/include/rte_version.h index 54cb9a6..356207c 100644 --- a/lib/librte_eal/common/include/rte_version.h +++ b/lib/librte_eal/common/include/rte_version.h @@ -104,13 +104,13 @@ rte_version(void) if (version[0] != 0) return version; if (strlen(RTE_VER_SUFFIX) == 0) - sprintf(version, "%s %d.%d.%d", + snprintf(version, sizeof(version), "%s %d.%d.%d", RTE_VER_PREFIX, RTE_VER_MAJOR, RTE_VER_MINOR, RTE_VER_PATCH_LEVEL); else - sprintf(version, "%s %d.%d.%d%s%d", + snprintf(version, sizeof(version), "%s %d.%d.%d%s%d", RTE_VER_PREFIX, RTE_VER_MAJOR, RTE_VER_MINOR, -- 1.9.3