From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Ananyev Subject: [PATCH] l3fwd-acl: fix possible memory leak. Date: Tue, 16 Dec 2014 17:05:08 +0000 Message-ID: <1418749508-17748-1-git-send-email-konstantin.ananyev@intel.com> To: dev-VfR2kkLFssw@public.gmane.org Return-path: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" At error app_acl_init() can return without freeing dynamically allocated memory. Not really a big problem, as if app_acl_init() fails, then application would terminate immediately anyway. Though it is a good coding practise to make a function to cleanup after itself. Signed-off-by: Konstantin Ananyev --- examples/l3fwd-acl/main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index 4487c95..022ccab 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -1247,6 +1247,10 @@ app_acl_init(void) acl_log("Socket %d of lcore %u is out " "of range %d\n", socketid, lcore_id, NB_SOCKETS); + free(route_base_ipv4); + free(route_base_ipv6); + free(acl_base_ipv4); + free(acl_base_ipv6); return -1; } -- 1.8.5.3