From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: [PATCH v2] xenvirt: Fix build break on cmdline_parse_etheraddr call Date: Thu, 18 Dec 2014 06:31:56 -0500 Message-ID: <1418902316-30266-1-git-send-email-nhorman@tuxdriver.com> References: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com> To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1418835808-18803-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Back in: commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db Author: Alan Carew Date: Fri Dec 5 15:19:07 2014 +0100 cmdline: fix overflow on bsd The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This patch makes the needed correction to avoid a build break Signed-off-by: Neil Horman CC: Thomas Monjalon CC: Olivier Matz --- Change notes v2: Changed sizeof(struct ether_addr) to sizeof(dict->addr) --- lib/librte_pmd_xenvirt/rte_eth_xenvirt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c index 6555ec5..04e30c9 100644 --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c @@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dict, if (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM, sizeof(RTE_ETH_XENVIRT_MAC_PARAM))) { if (cmdline_parse_etheraddr(NULL, - pair[1], - &dict->addr) < 0) { + pair[1], + &dict->addr, + sizeof(dict->addr)) < 0) { RTE_LOG(ERR, PMD, "Invalid %s device ether address\n", name); -- 1.9.3