From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: [PATCH] ixgbe: fix vector PMD chained mbuf receive Date: Fri, 6 Feb 2015 13:41:08 +0000 Message-ID: <1423230068-10841-1-git-send-email-bruce.richardson@intel.com> References: <54C261EC.8000104@allegro-packets.com> To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <54C261EC.8000104-CF7bWO6jhOGIrnxuYX0bhEEOCMrvLtNR@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" When the vector pmd was receiving a mix of packets of various sizes, some of which were split across multiple mbufs, there was an issue with reassembly of the jumbo frames. This was due to a skipped increment when using "continue" in a while loop. Changing the loop to a "for" loop fixes this problem, by ensuring the increment is always performed. Reported-by: Prashant Upadhyaya Reported-by: Martin Weiser Signed-off-by: Bruce Richardson Tested-by: Martin Weiser --- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c index b54cb19..dfaccee 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c @@ -402,10 +402,10 @@ reassemble_packets(struct igb_rx_queue *rxq, struct rte_mbuf **rx_bufs, struct rte_mbuf *pkts[RTE_IXGBE_VPMD_RX_BURST]; /*finished pkts*/ struct rte_mbuf *start = rxq->pkt_first_seg; struct rte_mbuf *end = rxq->pkt_last_seg; - unsigned pkt_idx = 0, buf_idx = 0; + unsigned pkt_idx, buf_idx; - while (buf_idx < nb_bufs) { + for (buf_idx = 0, pkt_idx = 0; buf_idx < nb_bufs; buf_idx++) { if (end != NULL) { /* processing a split packet */ end->next = rx_bufs[buf_idx]; @@ -448,7 +448,6 @@ reassemble_packets(struct igb_rx_queue *rxq, struct rte_mbuf **rx_bufs, rx_bufs[buf_idx]->data_len += rxq->crc_len; rx_bufs[buf_idx]->pkt_len += rxq->crc_len; } - buf_idx++; } /* save the partial packet for next time */ -- 2.1.0