From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cunming Liang Subject: [PATCH v1] afpacket: fix critical issue reported by klocwork Date: Thu, 12 Feb 2015 17:08:09 +0800 Message-ID: <1423732089-6202-1-git-send-email-cunming.liang@intel.com> To: dev-VfR2kkLFssw@public.gmane.org Return-path: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Klocwork report 'req' might be used uninitialized. In some cases it can 'goto error' when '*internals' not been set. The result is unexpected checking the value of '*internals'. Signed-off-by: Cunming Liang --- lib/librte_pmd_af_packet/rte_eth_af_packet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_af_packet/rte_eth_af_packet.c b/lib/librte_pmd_af_packet/rte_eth_af_packet.c index 1ffe1cd..185607d 100644 --- a/lib/librte_pmd_af_packet/rte_eth_af_packet.c +++ b/lib/librte_pmd_af_packet/rte_eth_af_packet.c @@ -439,13 +439,15 @@ rte_pmd_init_internals(const char *name, size_t ifnamelen; unsigned k_idx; struct sockaddr_ll sockaddr; - struct tpacket_req *req; + struct tpacket_req *req = NULL; struct pkt_rx_queue *rx_queue; struct pkt_tx_queue *tx_queue; int rc, qsockfd, tpver, discard; unsigned int i, q, rdsize; int fanout_arg __rte_unused, bypass __rte_unused; + *internals = NULL; + for (k_idx = 0; k_idx < kvlist->count; k_idx++) { pair = &kvlist->pairs[k_idx]; if (strstr(pair->key, ETH_AF_PACKET_IFACE_ARG) != NULL) -- 1.8.1.4