[PATCH] testpmd: Fix segmentation fault when portmask is specified

[PATCH] testpmd: Fix segmentation fault when portmask is specified

[Tetsuya Mukawa]

If testpmd is invoked with portmask option like below, segmentation
fault will be occured. This patch fixes the issue.

Reported-by: De Lara Guarch, Pablo <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
---
 app/test-pmd/testpmd.c | 37 +++++++++++++++++++++++--------------
 1 file changed, 23 insertions(+), 14 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 43329ed..61291be 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -579,20 +579,6 @@ init_config(void)
 						 socket_num);
 	}
 
-	/* Configuration of Ethernet ports. */
-	ports = rte_zmalloc("testpmd: ports",
-			    sizeof(struct rte_port) * RTE_MAX_ETHPORTS,
-			    RTE_CACHE_LINE_SIZE);
-	if (ports == NULL) {
-		rte_exit(EXIT_FAILURE,
-				"rte_zmalloc(%d struct rte_port) failed\n",
-				RTE_MAX_ETHPORTS);
-	}
-
-	/* enabled allocated ports */
-	for (pid = 0; pid < nb_ports; pid++)
-		ports[pid].enabled = 1;
-
 	FOREACH_PORT(pid, ports) {
 		port = &ports[pid];
 		rte_eth_dev_info_get(pid, &port->dev_info);
@@ -1999,6 +1985,26 @@ init_port_dcb_config(portid_t pid,struct dcb_config *dcb_conf)
 	return 0;
 }
 
+static void
+init_port(void)
+{
+	portid_t pid;
+
+	/* Configuration of Ethernet ports. */
+	ports = rte_zmalloc("testpmd: ports",
+			    sizeof(struct rte_port) * RTE_MAX_ETHPORTS,
+			    RTE_CACHE_LINE_SIZE);
+	if (ports == NULL) {
+		rte_exit(EXIT_FAILURE,
+				"rte_zmalloc(%d struct rte_port) failed\n",
+				RTE_MAX_ETHPORTS);
+	}
+
+	/* enabled allocated ports */
+	for (pid = 0; pid < nb_ports; pid++)
+		ports[pid].enabled = 1;
+}
+
 int
 main(int argc, char** argv)
 {
@@ -2013,6 +2019,9 @@ main(int argc, char** argv)
 	if (nb_ports == 0)
 		RTE_LOG(WARNING, EAL, "No probed ethernet devices\n");
 
+	/* allocate port structures, and init them */
+	init_port();
+
 	set_def_fwd_config();
 	if (nb_lcores == 0)
 		rte_panic("Empty set of forwarding logical cores - check the "
-- 
1.9.1

Re: [PATCH] testpmd: Fix segmentation fault when portmask is specified

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org]
> Sent: Friday, February 27, 2015 7:16 AM
> To: dev-VfR2kkLFssw@public.gmane.org
> Cc: De Lara Guarch, Pablo; Tetsuya Mukawa
> Subject: [PATCH] testpmd: Fix segmentation fault when portmask is
> specified
> 
> If testpmd is invoked with portmask option like below, segmentation
> fault will be occured. This patch fixes the issue.
> 
> Reported-by: De Lara Guarch, Pablo <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
> ---
>  app/test-pmd/testpmd.c | 37 +++++++++++++++++++++++--------------
>  1 file changed, 23 insertions(+), 14 deletions(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 43329ed..61291be 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -579,20 +579,6 @@ init_config(void)
>  						 socket_num);
>  	}
> 
> -	/* Configuration of Ethernet ports. */
> -	ports = rte_zmalloc("testpmd: ports",
> -			    sizeof(struct rte_port) * RTE_MAX_ETHPORTS,
> -			    RTE_CACHE_LINE_SIZE);
> -	if (ports == NULL) {
> -		rte_exit(EXIT_FAILURE,
> -				"rte_zmalloc(%d struct rte_port) failed\n",
> -				RTE_MAX_ETHPORTS);
> -	}
> -
> -	/* enabled allocated ports */
> -	for (pid = 0; pid < nb_ports; pid++)
> -		ports[pid].enabled = 1;
> -
>  	FOREACH_PORT(pid, ports) {
>  		port = &ports[pid];
>  		rte_eth_dev_info_get(pid, &port->dev_info);
> @@ -1999,6 +1985,26 @@ init_port_dcb_config(portid_t pid,struct
> dcb_config *dcb_conf)
>  	return 0;
>  }
> 
> +static void
> +init_port(void)
> +{
> +	portid_t pid;
> +
> +	/* Configuration of Ethernet ports. */
> +	ports = rte_zmalloc("testpmd: ports",
> +			    sizeof(struct rte_port) * RTE_MAX_ETHPORTS,
> +			    RTE_CACHE_LINE_SIZE);
> +	if (ports == NULL) {
> +		rte_exit(EXIT_FAILURE,
> +				"rte_zmalloc(%d struct rte_port) failed\n",
> +				RTE_MAX_ETHPORTS);
> +	}
> +
> +	/* enabled allocated ports */
> +	for (pid = 0; pid < nb_ports; pid++)
> +		ports[pid].enabled = 1;
> +}
> +
>  int
>  main(int argc, char** argv)
>  {
> @@ -2013,6 +2019,9 @@ main(int argc, char** argv)
>  	if (nb_ports == 0)
>  		RTE_LOG(WARNING, EAL, "No probed ethernet devices\n");
> 
> +	/* allocate port structures, and init them */
> +	init_port();
> +
>  	set_def_fwd_config();
>  	if (nb_lcores == 0)
>  		rte_panic("Empty set of forwarding logical cores - check the "
> --
> 1.9.1

Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Re: [PATCH] testpmd: Fix segmentation fault when portmask is specified

[Thomas Monjalon]

> > If testpmd is invoked with portmask option like below, segmentation
> > fault will be occured. This patch fixes the issue.
> > 
> > Reported-by: De Lara Guarch, Pablo <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Applied, thanks

Re: [PATCH] testpmd: Fix segmentation fault when portmask is specified

[Fu, JingguoX]

Tested-by: Jingguo Fu <jingguox.fu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
 
- Tested Commit: 8a6f6d45d290a27ef923d10925c4893380697b31
- OS: Fedora20 3.11.10-301.fc20.x86_64
- GCC: gcc version 4.8.3 20140911
- CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz
- NIC: Intel Corporation Device [8086:1563]
- Default x86_64-native-linuxapp-gcc configuration
- Total 1 case, 1 passed, 0 failed
 
- Case: test_checksum_checking
  Description: Check testpmd can be startup with cmdline for checksum
  Command / instruction:
      Start testpmd with command line as:
          ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x1fffffffff -n 4  -- -i --coremask=0x400 --portmask=0x3 --nb-cores=2 --enable-rx-cksum --disable-hw-vlan --disable-rss --rxd=1024 --txd=1024 --rxfreet=0
      Start ports:
          set fwd cusm
          start
      Expected test result:
          Testpmd can startup.

-----Original Message-----
From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Tetsuya Mukawa
Sent: Friday, February 27, 2015 15:16
To: dev-VfR2kkLFssw@public.gmane.org
Subject: [dpdk-dev] [PATCH] testpmd: Fix segmentation fault when portmask is specified

If testpmd is invoked with portmask option like below, segmentation
fault will be occured. This patch fixes the issue.

Reported-by: De Lara Guarch, Pablo <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
---
 app/test-pmd/testpmd.c | 37 +++++++++++++++++++++++--------------
 1 file changed, 23 insertions(+), 14 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 43329ed..61291be 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -579,20 +579,6 @@ init_config(void)
 						 socket_num);
 	}
 
-	/* Configuration of Ethernet ports. */
-	ports = rte_zmalloc("testpmd: ports",
-			    sizeof(struct rte_port) * RTE_MAX_ETHPORTS,
-			    RTE_CACHE_LINE_SIZE);
-	if (ports == NULL) {
-		rte_exit(EXIT_FAILURE,
-				"rte_zmalloc(%d struct rte_port) failed\n",
-				RTE_MAX_ETHPORTS);
-	}
-
-	/* enabled allocated ports */
-	for (pid = 0; pid < nb_ports; pid++)
-		ports[pid].enabled = 1;
-
 	FOREACH_PORT(pid, ports) {
 		port = &ports[pid];
 		rte_eth_dev_info_get(pid, &port->dev_info);
@@ -1999,6 +1985,26 @@ init_port_dcb_config(portid_t pid,struct dcb_config *dcb_conf)
 	return 0;
 }
 
+static void
+init_port(void)
+{
+	portid_t pid;
+
+	/* Configuration of Ethernet ports. */
+	ports = rte_zmalloc("testpmd: ports",
+			    sizeof(struct rte_port) * RTE_MAX_ETHPORTS,
+			    RTE_CACHE_LINE_SIZE);
+	if (ports == NULL) {
+		rte_exit(EXIT_FAILURE,
+				"rte_zmalloc(%d struct rte_port) failed\n",
+				RTE_MAX_ETHPORTS);
+	}
+
+	/* enabled allocated ports */
+	for (pid = 0; pid < nb_ports; pid++)
+		ports[pid].enabled = 1;
+}
+
 int
 main(int argc, char** argv)
 {
@@ -2013,6 +2019,9 @@ main(int argc, char** argv)
 	if (nb_ports == 0)
 		RTE_LOG(WARNING, EAL, "No probed ethernet devices\n");
 
+	/* allocate port structures, and init them */
+	init_port();
+
 	set_def_fwd_config();
 	if (nb_lcores == 0)
 		rte_panic("Empty set of forwarding logical cores - check the "
-- 
1.9.1