From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pawel Wodkowski Subject: [PATCH] eal: prevent dereferencing NULL pointer in rte_eal_devargs_add() Date: Mon, 2 Mar 2015 12:09:22 +0100 Message-ID: <1425294562-26015-1-git-send-email-pawelx.wodkowski@intel.com> To: dev-VfR2kkLFssw@public.gmane.org Return-path: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On failure devargs->args should not be accesed if devargs is NULL. Signed-off-by: Pawel Wodkowski --- lib/librte_eal/common/eal_common_devargs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 9b110f7..615945e 100644 --- a/lib/librte_eal/common/eal_common_devargs.c +++ b/lib/librte_eal/common/eal_common_devargs.c @@ -124,12 +124,13 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str) return 0; fail: - if (devargs->args) - free(devargs->args); if (buf) free(buf); - if (devargs) + if (devargs) { + free(devargs->args); free(devargs); + } + return -1; } -- 1.9.1