* [PATCH] librte_pmd_e1000: power down the serdes link
@ 2015-03-07 3:57 Shelton Chia
[not found] ` <1425700658-12077-1-git-send-email-jiaxt-ZrUwlr9QczFWk0Htik3J/w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Shelton Chia @ 2015-03-07 3:57 UTC (permalink / raw)
To: dev-VfR2kkLFssw
Signed-off-by: Shelton Chia <jiaxt-ZrUwlr9QczFWk0Htik3J/w@public.gmane.org>
---
lib/librte_pmd_e1000/igb_ethdev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c
index 504ae74..314ef2a 100644
--- a/lib/librte_pmd_e1000/igb_ethdev.c
+++ b/lib/librte_pmd_e1000/igb_ethdev.c
@@ -948,7 +948,10 @@ eth_igb_stop(struct rte_eth_dev *dev)
}
/* Power down the phy. Needed to make the link go Down */
- e1000_power_down_phy(hw);
+ if (hw->phy.media_type == e1000_media_type_copper)
+ e1000_power_down_phy(hw);
+ else
+ e1000_shutdown_fiber_serdes_link(hw);
igb_dev_clear_queues(dev);
--
2.3.0
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1425700658-12077-1-git-send-email-jiaxt-ZrUwlr9QczFWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH] librte_pmd_e1000: power down the serdes link [not found] ` <1425700658-12077-1-git-send-email-jiaxt-ZrUwlr9QczFWk0Htik3J/w@public.gmane.org> @ 2015-03-23 11:40 ` Thomas Monjalon 2015-03-30 20:30 ` Thomas Monjalon 1 sibling, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2015-03-23 11:40 UTC (permalink / raw) To: dev-VfR2kkLFssw There is no maintainer declared for e1000. Maybe that an Intel expert could check this patch, please? 2015-03-07 11:57, Shelton Chia: > Signed-off-by: Shelton Chia <jiaxt-ZrUwlr9QczFWk0Htik3J/w@public.gmane.org> > --- > lib/librte_pmd_e1000/igb_ethdev.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c > index 504ae74..314ef2a 100644 > --- a/lib/librte_pmd_e1000/igb_ethdev.c > +++ b/lib/librte_pmd_e1000/igb_ethdev.c > @@ -948,7 +948,10 @@ eth_igb_stop(struct rte_eth_dev *dev) > } > > /* Power down the phy. Needed to make the link go Down */ > - e1000_power_down_phy(hw); > + if (hw->phy.media_type == e1000_media_type_copper) > + e1000_power_down_phy(hw); > + else > + e1000_shutdown_fiber_serdes_link(hw); > > igb_dev_clear_queues(dev); > > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] librte_pmd_e1000: power down the serdes link [not found] ` <1425700658-12077-1-git-send-email-jiaxt-ZrUwlr9QczFWk0Htik3J/w@public.gmane.org> 2015-03-23 11:40 ` Thomas Monjalon @ 2015-03-30 20:30 ` Thomas Monjalon 1 sibling, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2015-03-30 20:30 UTC (permalink / raw) To: Shelton Chia; +Cc: dev-VfR2kkLFssw 2015-03-07 11:57, Shelton Chia: > Signed-off-by: Shelton Chia <jiaxt-ZrUwlr9QczFWk0Htik3J/w@public.gmane.org> > --- > lib/librte_pmd_e1000/igb_ethdev.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c > index 504ae74..314ef2a 100644 > --- a/lib/librte_pmd_e1000/igb_ethdev.c > +++ b/lib/librte_pmd_e1000/igb_ethdev.c > @@ -948,7 +948,10 @@ eth_igb_stop(struct rte_eth_dev *dev) > } > > /* Power down the phy. Needed to make the link go Down */ > - e1000_power_down_phy(hw); > + if (hw->phy.media_type == e1000_media_type_copper) > + e1000_power_down_phy(hw); > + else > + e1000_shutdown_fiber_serdes_link(hw); > > igb_dev_clear_queues(dev); Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> Applied, thanks ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-30 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-07 3:57 [PATCH] librte_pmd_e1000: power down the serdes link Shelton Chia
[not found] ` <1425700658-12077-1-git-send-email-jiaxt-ZrUwlr9QczFWk0Htik3J/w@public.gmane.org>
2015-03-23 11:40 ` Thomas Monjalon
2015-03-30 20:30 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).