From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Liu Subject: [PATCH 3/6] fix build error when initialized structure in enic driver Date: Thu, 19 Mar 2015 11:16:55 +0800 Message-ID: <1426735018-19411-6-git-send-email-yong.liu@intel.com> References: <1426735018-19411-1-git-send-email-yong.liu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1426735018-19411-1-git-send-email-yong.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" From: Marvin Liu gcc4.3 will raise warnings in blow code for initialized field overwritten= . enic_main.c: In function =E2=80=98enic_set_rsskey=E2=80=99: enic_main.c:845: error: initialized field overwritten enic_main.c:845: error: (near initialization for =E2=80=98rss_key.key=E2=80= =99) enic_main.c:846: error: initialized field overwritten enic_main.c:846: error: (near initialization for =E2=80=98rss_key.key=E2=80= =99) enic_main.c:847: error: initialized field overwritten enic_main.c:847: error: (near initialization for =E2=80=98rss_key.key=E2=80= =99) static union vnic_rss_key rss_key =3D { .key[0] =3D ..., .key[1] =3D ..., .key[2] =3D ..., .key[3] =3D ..., }; Change struct initialized code reference to ISO 9899 section 6.7.8. gcc4.3 will happy for that. static union vnic_rss_key rss_key =3D { .key =3D { [0] =3D ..., [1] =3D ..., [2] =3D ..., [3] =3D ..., } Signed-off-by: Marvin Liu diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_m= ain.c index c66f139..0892b3e 100644 --- a/lib/librte_pmd_enic/enic_main.c +++ b/lib/librte_pmd_enic/enic_main.c @@ -840,10 +840,12 @@ static int enic_set_rsskey(struct enic *enic) dma_addr_t rss_key_buf_pa; union vnic_rss_key *rss_key_buf_va =3D NULL; static union vnic_rss_key rss_key =3D { - .key[0] =3D {.b =3D {85, 67, 83, 97, 119, 101, 115, 111, 109, 101}}, - .key[1] =3D {.b =3D {80, 65, 76, 79, 117, 110, 105, 113, 117, 101}}, - .key[2] =3D {.b =3D {76, 73, 78, 85, 88, 114, 111, 99, 107, 115}}, - .key[3] =3D {.b =3D {69, 78, 73, 67, 105, 115, 99, 111, 111, 108}}, + .key =3D { + [0] =3D {.b =3D {85, 67, 83, 97, 119, 101, 115, 111, 109, 101}}, + [1] =3D {.b =3D {80, 65, 76, 79, 117, 110, 105, 113, 117, 101}}, + [2] =3D {.b =3D {76, 73, 78, 85, 88, 114, 111, 99, 107, 115}}, + [3] =3D {.b =3D {69, 78, 73, 67, 105, 115, 99, 111, 111, 108}}, + } }; int err; u8 name[NAME_MAX]; --=20 1.9.3