From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH 1/2] log: rte_openlog_stream should be void Date: Fri, 17 Apr 2015 08:35:33 -0700 Message-ID: <1429284934-3261-2-git-send-email-stephen@networkplumber.org> References: <1429284934-3261-1-git-send-email-stephen@networkplumber.org> To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1429284934-3261-1-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Function always returned 0 and no one was checking anyway. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_log.c | 3 +-- lib/librte_eal/common/include/rte_log.h | 5 +---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c index ff44d23..3802f9c 100644 --- a/lib/librte_eal/common/eal_common_log.c +++ b/lib/librte_eal/common/eal_common_log.c @@ -158,14 +158,13 @@ rte_log_set_history(int enable) } /* Change the stream that will be used by logging system */ -int +void rte_openlog_stream(FILE *f) { if (f == NULL) rte_logs.file = default_log_stream; else rte_logs.file = f; - return 0; } /* Set global log level */ diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h index f83a0d9..888ee19 100644 --- a/lib/librte_eal/common/include/rte_log.h +++ b/lib/librte_eal/common/include/rte_log.h @@ -110,11 +110,8 @@ extern FILE *eal_default_log_stream; * * @param f * Pointer to the stream. - * @return - * - 0 on success. - * - Negative on error. */ -int rte_openlog_stream(FILE *f); +void rte_openlog_stream(FILE *f); /** * Set the global log level. -- 2.1.4