From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: [RFC PATCH 6/8] virtio: remove header inclusion of rte_mbuf.h Date: Thu, 23 Apr 2015 14:03:55 +0100 Message-ID: <1429794237-9498-7-git-send-email-bruce.richardson@intel.com> References: <1429794237-9498-1-git-send-email-bruce.richardson@intel.com> To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1429794237-9498-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" The virtqueue header files include the mbuf header file, but they do not need to do so as they only use pointers to the struct rte_mbuf type, and do not use any of the mbuf internals, nor any of the mbuf functions or macros. Therefore the inclusion is unnecessary, and can be replaced by a forward declaration of the mbuf type. Signed-off-by: Bruce Richardson --- lib/librte_pmd_virtio/virtqueue.h | 3 ++- lib/librte_pmd_xenvirt/virtqueue.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_virtio/virtqueue.h b/lib/librte_pmd_virtio/virtqueue.h index 41dda50..9d6079e 100644 --- a/lib/librte_pmd_virtio/virtqueue.h +++ b/lib/librte_pmd_virtio/virtqueue.h @@ -37,7 +37,6 @@ #include #include -#include #include #include #include @@ -46,6 +45,8 @@ #include "virtio_ring.h" #include "virtio_logs.h" +struct rte_mbuf; + /* * Per virtio_config.h in Linux. * For virtio_pci on SMP, we don't need to order with respect to MMIO diff --git a/lib/librte_pmd_xenvirt/virtqueue.h b/lib/librte_pmd_xenvirt/virtqueue.h index 34a24fc..eff6208 100644 --- a/lib/librte_pmd_xenvirt/virtqueue.h +++ b/lib/librte_pmd_xenvirt/virtqueue.h @@ -42,10 +42,11 @@ #include #include #include -#include #include "virtio_logs.h" +struct rte_mbuf; + /* The alignment to use between consumer and producer parts of vring. */ #define VIRTIO_PCI_VRING_ALIGN 4096 -- 2.1.0