From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/3] ixgbe: Add L2 Ethertype, SYN and Five tuple queue filters Date: Wed, 28 May 2014 01:09:47 +0200 Message-ID: <1431824.kSt8MFELsZ@xps13> References: <1400543506-24717-1-git-send-email-medvedkinv@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Vladimir Medvedkin Return-path: In-Reply-To: <1400543506-24717-1-git-send-email-medvedkinv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Vladimir, Seems like hardware filtering becomes useful these days :) 2014-05-19 19:51, Vladimir Medvedkin: > This patchset adds in addition to the Flow Director filters L2 Ethertype, > SYN and Five tuple queue filters to route packets according to ethertype, > l4 proto, source/destination ip/ports pool and presence of SYN flag in TCP > packet. Unlike http://dpdk.org/ml/archives/dev/2014-May/002512.html this > gives capability to work with pools. This patch functionality can be merged > with the patch above. 2 comments: 1) Do you have a good confidence that this new API is generic enough to be used by other NICs than ixgbe? 2) Could you try to check your patches with the kernel script checkpatch.pl, please? Thanks -- Thomas