From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH 2/5] ethdev: remove unnecessary checks Date: Mon, 18 May 2015 10:40:11 -0700 Message-ID: <1431970814-25951-3-git-send-email-stephen@networkplumber.org> References: <1431970814-25951-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org To: cumming.lian@intel.com Return-path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id F2C01C31A for ; Mon, 18 May 2015 19:40:13 +0200 (CEST) Received: by pabts4 with SMTP id ts4so160749950pab.3 for ; Mon, 18 May 2015 10:40:13 -0700 (PDT) In-Reply-To: <1431970814-25951-1-git-send-email-stephen@networkplumber.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since the code has just called rte_eth_dev_is_valid_port the following checks are unnecessary. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index ad15837..7789338 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -3305,10 +3305,6 @@ rte_eth_dev_rx_intr_ctl(uint8_t port_id, int epfd, int op, void *data) } dev = &rte_eth_devices[port_id]; - if (dev == NULL) { - PMD_DEBUG_TRACE("Invalid port device\n"); - return -ENODEV; - } intr_handle = &dev->pci_dev->intr_handle; if (!intr_handle->intr_vec) { @@ -3350,10 +3346,6 @@ rte_eth_dev_rx_intr_ctl_q(uint8_t port_id, uint16_t queue_id, } dev = &rte_eth_devices[port_id]; - if (dev == NULL) { - PMD_DEBUG_TRACE("Invalid port device\n"); - return -ENODEV; - } if (queue_id >= dev->data->nb_rx_queues) { PMD_DEBUG_TRACE("Invalid RX queue_id=%d\n", rx_queue_id); @@ -3391,10 +3383,6 @@ rte_eth_dev_rx_intr_enable(uint8_t port_id, } dev = &rte_eth_devices[port_id]; - if (dev == NULL) { - PMD_DEBUG_TRACE("Invalid port device\n"); - return -ENODEV; - } FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_enable, -ENOTSUP); return (*dev->dev_ops->rx_queue_intr_enable)(dev, queue_id); @@ -3412,10 +3400,6 @@ rte_eth_dev_rx_intr_disable(uint8_t port_id, } dev = &rte_eth_devices[port_id]; - if (dev == NULL) { - PMD_DEBUG_TRACE("Invalid port device\n"); - return -ENODEV; - } FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_intr_disable, -ENOTSUP); return (*dev->dev_ops->rx_queue_intr_disable)(dev, queue_id); -- 2.1.4