From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: [PATCH 1/2] mempool: fix returned value on 64 bit after counting objects Date: Mon, 25 May 2015 18:27:45 +0200 Message-ID: <1432571266-25840-1-git-send-email-adrien.mazarguil@6wind.com> To: dev@dpdk.org Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id D05ABB3D6 for ; Mon, 25 May 2015 18:27:55 +0200 (CEST) Received: by wicmc15 with SMTP id mc15so44219956wic.1 for ; Mon, 25 May 2015 09:27:55 -0700 (PDT) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id w11sm16943094wjr.48.2015.05.25.09.27.54 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 25 May 2015 09:27:54 -0700 (PDT) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_mempool_xmem_usage()'s return type is ssize_t which has the same architecture-dependent width as size_t but is signed. On 64-bit architectures, returning a negative uint32_t value without casting to ssize_t first does not work as intended, the sign bit is lost and the returned value is garbage. This commit fixes an assertion failure in testpmd on 64 bit architectures when combining --no-huge and --mp-anon outside of Xen Dom0: PANIC in mempool_anon_create(): line 170 assert "elt_num == mp->size" failed Fixes: 148f963fb532 ("xen: core library changes") Signed-off-by: Adrien Mazarguil --- lib/librte_mempool/rte_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 01972ba..d1a02a2 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c @@ -361,7 +361,7 @@ rte_mempool_xmem_usage(void *vaddr, uint32_t elt_num, size_t elt_sz, if ((n = rte_mempool_obj_iter(vaddr, elt_num, elt_sz, 1, paddr, pg_num, pg_shift, mempool_lelem_iter, &uv)) != elt_num) { - return (-n); + return (-(ssize_t)n); } uv = RTE_ALIGN_CEIL(uv, pg_sz); -- 2.1.0