From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH 1/5] virtio: remove blank lines Date: Thu, 11 Jun 2015 08:53:23 -0700 Message-ID: <1434038007-8964-2-git-send-email-stephen@networkplumber.org> References: <1434038007-8964-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org, Stephen Hemminger To: changchun.ouyang@intel.com Return-path: Received: from mail-qg0-f43.google.com (mail-qg0-f43.google.com [209.85.192.43]) by dpdk.org (Postfix) with ESMTP id 286CE5A54 for ; Thu, 11 Jun 2015 17:53:29 +0200 (CEST) Received: by qgfa66 with SMTP id a66so3299769qgf.0 for ; Thu, 11 Jun 2015 08:53:28 -0700 (PDT) In-Reply-To: <1434038007-8964-1-git-send-email-stephen@networkplumber.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger Putting blank line between function and following conditional just wastes screen space, and makes code less obvious. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_ethdev.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index f74e413..77f18a0 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -228,7 +228,6 @@ virtio_set_multiple_queues(struct rte_eth_dev *dev, uint16_t nb_queues) dlen[0] = sizeof(uint16_t); ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); - if (ret) { PMD_INIT_LOG(ERR, "Multiqueue configured but send command " "failed, this is too late now..."); @@ -394,7 +393,6 @@ virtio_dev_cq_queue_setup(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx, PMD_INIT_FUNC_TRACE(); ret = virtio_dev_queue_setup(dev, VTNET_CQ, VTNET_SQ_CQ_QUEUE_IDX, vtpci_queue_idx, nb_desc, socket_id, &vq); - if (ret < 0) { PMD_INIT_LOG(ERR, "control vq initialization failed"); return ret; @@ -434,7 +432,6 @@ virtio_dev_promiscuous_enable(struct rte_eth_dev *dev) dlen[0] = 1; ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); - if (ret) PMD_INIT_LOG(ERR, "Failed to enable promisc"); } @@ -453,7 +450,6 @@ virtio_dev_promiscuous_disable(struct rte_eth_dev *dev) dlen[0] = 1; ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); - if (ret) PMD_INIT_LOG(ERR, "Failed to disable promisc"); } @@ -472,7 +468,6 @@ virtio_dev_allmulticast_enable(struct rte_eth_dev *dev) dlen[0] = 1; ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); - if (ret) PMD_INIT_LOG(ERR, "Failed to enable allmulticast"); } @@ -491,7 +486,6 @@ virtio_dev_allmulticast_disable(struct rte_eth_dev *dev) dlen[0] = 1; ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); - if (ret) PMD_INIT_LOG(ERR, "Failed to disable allmulticast"); } -- 2.1.4