From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Qiu Subject: [PATCH] testpmd: Fix wrong message in testpmd Date: Wed, 24 Jun 2015 15:56:25 +0800 Message-ID: <1435132585-10192-1-git-send-email-michael.qiu@intel.com> To: dev@dpdk.org Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D0C745FEB for ; Wed, 24 Jun 2015 09:56:51 +0200 (CEST) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When close one port twice, testpmd will give out wrong messagse. testpmd> port stop 0 Stopping ports... Checking link statuses... Port 0 Link Up - speed 0 Mbps - full-duplex Port 1 Link Up - speed 0 Mbps - full-duplex Done testpmd> port close 0 Closing ports... Done testpmd> port close 0 Closing ports... Port 0 is now not stopped Done testpmd> Signed-off-by: Michael Qiu --- app/test-pmd/testpmd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 3057791..907cda3 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1534,6 +1534,12 @@ close_port(portid_t pid) port = &ports[pi]; if (rte_atomic16_cmpset(&(port->port_status), + RTE_PORT_CLOSED, RTE_PORT_CLOSED) == 1) { + printf("Port %d is already closed\n", pi); + continue; + } + + if (rte_atomic16_cmpset(&(port->port_status), RTE_PORT_STOPPED, RTE_PORT_HANDLING) == 0) { printf("Port %d is now not stopped\n", pi); continue; -- 2.1.0