From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH 04/11] eth: remove unnecessary return value Date: Fri, 24 Jul 2015 10:06:17 -0700 Message-ID: <1437757584-15502-5-git-send-email-stephen@networkplumber.org> References: <1437757584-15502-1-git-send-email-stephen@networkplumber.org> To: dev@dpdk.org Return-path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 7E6C7C482 for ; Fri, 24 Jul 2015 19:06:23 +0200 (CEST) Received: by pacan13 with SMTP id an13so17465611pac.1 for ; Fri, 24 Jul 2015 10:06:22 -0700 (PDT) In-Reply-To: <1437757584-15502-1-git-send-email-stephen@networkplumber.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Eliminate unnecessary variable for return value Found with returnvar.cocci Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index a96cd4f..d72fa8e 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -1892,7 +1892,6 @@ int rte_eth_dev_set_vlan_offload(uint8_t port_id, int offload_mask) { struct rte_eth_dev *dev; - int ret = 0; int mask = 0; int cur, org = 0; @@ -1921,14 +1920,14 @@ rte_eth_dev_set_vlan_offload(uint8_t port_id, int offload_mask) mask |= ETH_VLAN_EXTEND_MASK; } - /*no change*/ + /* no change */ if (mask == 0) - return ret; + return 0; FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_offload_set, -ENOTSUP); (*dev->dev_ops->vlan_offload_set)(dev, mask); - return ret; + return 0; } int -- 2.1.4