From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: [PATCH v3] eal: make hugetlb initialization more
	robust
Date: Tue, 10 May 2016 09:54:33 +0100
Message-ID: <1437de5d-b233-0c2a-7181-39d267c395c4@intel.com>
References: <1457089092-4128-1-git-send-email-jianfeng.tan@intel.com>
 <1462790934-87685-1-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: david.marchand@6wind.com, nhorman@tuxdriver.com
To: Jianfeng Tan <jianfeng.tan@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id E8C4895D8
 for <dev@dpdk.org>; Tue, 10 May 2016 10:54:35 +0200 (CEST)
In-Reply-To: <1462790934-87685-1-git-send-email-jianfeng.tan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


Hi Jianfeng,

On 09/05/2016 11:48, Jianfeng Tan wrote:

>   		/* find physical addresses and sockets for each hugepage */
> @@ -1172,8 +1255,9 @@ rte_eal_hugepage_init(void)
>   		hp_offset += new_pages_count[i];
>   #else
>   		/* remap all hugepages */
> -		if (map_all_hugepages(&tmp_hp[hp_offset], hpi, 0) < 0){
> -			RTE_LOG(DEBUG, EAL, "Failed to remap %u MB pages\n",
> +		if ((uint32_t)map_all_hugepages(&tmp_hp[hp_offset], hpi, 0) !=
> +		    hpi->num_pages[0]) {

It probably makes more sense to have map_all_hugepages return uint32_t 
instead.

Sergio