From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] bus/pci: fix unexpected resource mapping
	override
Date: Wed, 26 Sep 2018 15:50:47 +0200
Message-ID: <14389377.uLlNGEYteW@xps>
References: <20180903084005.29706-1-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com,
 geoffrey.lv@gmail.com, ajit.khaparde@broadcom.com, stable@dpdk.org
To: Qi Zhang <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180903084005.29706-1-qi.z.zhang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

03/09/2018 10:40, Qi Zhang:
> When scanning an already plugged device, the virtual address
> of mapped PCI resource in rte_pci_device will be overridden
> with 0, that may cause driver does not work correctly.

Why is it overridden with 0?
Can we try to fix the root cause?

> The fix is not to update any rte_pci_device's field if the being
> scanned device's driver is already probed.

I am going to send a patch to have a safer way of checking
whether a device is probed or not.
If this change is really needed, I suggest to rebase it on top my patch.