From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Aloni Subject: [PATCH] mempool: fix the inverted pg_num check on create Date: Sun, 16 Aug 2015 22:08:19 +0300 Message-ID: <1439752099-23090-1-git-send-email-dan@kernelim.com> Cc: dev@dpdk.org To: Olivier Matz Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 5D25E8E5C for ; Sun, 16 Aug 2015 21:09:04 +0200 (CEST) Received: by wicja10 with SMTP id ja10so55442464wic.1 for ; Sun, 16 Aug 2015 12:09:04 -0700 (PDT) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rest of the code expects pg_num <= RTE_DIM(mp->elt_pa). Signed-off-by: Dan Aloni --- lib/librte_mempool/rte_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 8e185c545479..edcfa8bf9cb1 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c @@ -461,7 +461,7 @@ rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size, } /* Check that pg_num and pg_shift parameters are valid. */ - if (pg_num < RTE_DIM(mp->elt_pa) || pg_shift > MEMPOOL_PG_SHIFT_MAX) { + if (pg_num > RTE_DIM(mp->elt_pa) || pg_shift > MEMPOOL_PG_SHIFT_MAX) { rte_errno = EINVAL; return NULL; } -- 2.4.3