* [PATCH] net/intel: update key_len when getting RSS key
@ 2026-01-12 13:53 Thierry Herbelot
2026-01-16 13:02 ` Bruce Richardson
2026-01-16 13:54 ` [V2] " Thierry Herbelot
0 siblings, 2 replies; 5+ messages in thread
From: Thierry Herbelot @ 2026-01-12 13:53 UTC (permalink / raw)
To: dev
Cc: Thierry Herbelot, Thomas Monjalon, Bruce Richardson,
Anatoly Burakov, stable, Olivier Matz
When adding the i40e PMD, the rss_hash_conf_get function was changed to
update the RSS key len.
The corresponding functions for ixgbe & e1000 were not updated to
follow the new convention.
Fixes: 8a387fa85f02 ("ethdev: more RSS flags")
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
drivers/net/intel/e1000/igb_rxtx.c | 1 +
drivers/net/intel/e1000/igc_ethdev.c | 1 +
drivers/net/intel/ixgbe/ixgbe_rxtx.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/net/intel/e1000/igb_rxtx.c b/drivers/net/intel/e1000/igb_rxtx.c
index cdd7a3338f61..d5c2bc013702 100644
--- a/drivers/net/intel/e1000/igb_rxtx.c
+++ b/drivers/net/intel/e1000/igb_rxtx.c
@@ -2042,6 +2042,7 @@ int eth_igb_rss_hash_conf_get(struct rte_eth_dev *dev,
hash_key[(i * 4) + 2] = (rss_key >> 16) & 0x000000FF;
hash_key[(i * 4) + 3] = (rss_key >> 24) & 0x000000FF;
}
+ rss_conf->rss_key_len = 40;
}
/* Get RSS functions configured in MRQC register */
diff --git a/drivers/net/intel/e1000/igc_ethdev.c b/drivers/net/intel/e1000/igc_ethdev.c
index b9c91d2446c0..9f6ada3bc6cd 100644
--- a/drivers/net/intel/e1000/igc_ethdev.c
+++ b/drivers/net/intel/e1000/igc_ethdev.c
@@ -2559,6 +2559,7 @@ eth_igc_rss_hash_conf_get(struct rte_eth_dev *dev,
/* read RSS key from register */
for (i = 0; i < IGC_HKEY_MAX_INDEX; i++)
hash_key[i] = E1000_READ_REG_LE_VALUE(hw, E1000_RSSRK(i));
+ rss_conf->rss_key_len = IGC_HKEY_MAX_INDEX * sizeof(uint32_t);
}
/* get RSS functions configured in MRQC register */
diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
index a7583c178a14..a2c5ffe0b3b0 100644
--- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
@@ -3756,6 +3756,7 @@ ixgbe_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
hash_key[(i * 4) + 2] = (rss_key >> 16) & 0x000000FF;
hash_key[(i * 4) + 3] = (rss_key >> 24) & 0x000000FF;
}
+ rss_conf->rss_key_len = 40;
}
if (!ixgbe_rss_enabled(hw)) { /* RSS is disabled */
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net/intel: update key_len when getting RSS key
2026-01-12 13:53 [PATCH] net/intel: update key_len when getting RSS key Thierry Herbelot
@ 2026-01-16 13:02 ` Bruce Richardson
2026-01-16 13:11 ` Thierry Herbelot
2026-01-16 13:54 ` [V2] " Thierry Herbelot
1 sibling, 1 reply; 5+ messages in thread
From: Bruce Richardson @ 2026-01-16 13:02 UTC (permalink / raw)
To: Thierry Herbelot
Cc: dev, Thomas Monjalon, Anatoly Burakov, stable, Olivier Matz
On Mon, Jan 12, 2026 at 02:53:11PM +0100, Thierry Herbelot wrote:
> When adding the i40e PMD, the rss_hash_conf_get function was changed to
> update the RSS key len.
> The corresponding functions for ixgbe & e1000 were not updated to
> follow the new convention.
>
> Fixes: 8a387fa85f02 ("ethdev: more RSS flags")
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
> drivers/net/intel/e1000/igb_rxtx.c | 1 +
> drivers/net/intel/e1000/igc_ethdev.c | 1 +
> drivers/net/intel/ixgbe/ixgbe_rxtx.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/net/intel/e1000/igb_rxtx.c b/drivers/net/intel/e1000/igb_rxtx.c
> index cdd7a3338f61..d5c2bc013702 100644
> --- a/drivers/net/intel/e1000/igb_rxtx.c
> +++ b/drivers/net/intel/e1000/igb_rxtx.c
> @@ -2042,6 +2042,7 @@ int eth_igb_rss_hash_conf_get(struct rte_eth_dev *dev,
> hash_key[(i * 4) + 2] = (rss_key >> 16) & 0x000000FF;
> hash_key[(i * 4) + 3] = (rss_key >> 24) & 0x000000FF;
> }
> + rss_conf->rss_key_len = 40;
> }
>
> /* Get RSS functions configured in MRQC register */
> diff --git a/drivers/net/intel/e1000/igc_ethdev.c b/drivers/net/intel/e1000/igc_ethdev.c
> index b9c91d2446c0..9f6ada3bc6cd 100644
> --- a/drivers/net/intel/e1000/igc_ethdev.c
> +++ b/drivers/net/intel/e1000/igc_ethdev.c
> @@ -2559,6 +2559,7 @@ eth_igc_rss_hash_conf_get(struct rte_eth_dev *dev,
> /* read RSS key from register */
> for (i = 0; i < IGC_HKEY_MAX_INDEX; i++)
> hash_key[i] = E1000_READ_REG_LE_VALUE(hw, E1000_RSSRK(i));
> + rss_conf->rss_key_len = IGC_HKEY_MAX_INDEX * sizeof(uint32_t);
> }
>
> /* get RSS functions configured in MRQC register */
> diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
> index a7583c178a14..a2c5ffe0b3b0 100644
> --- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
> @@ -3756,6 +3756,7 @@ ixgbe_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
> hash_key[(i * 4) + 2] = (rss_key >> 16) & 0x000000FF;
> hash_key[(i * 4) + 3] = (rss_key >> 24) & 0x000000FF;
> }
> + rss_conf->rss_key_len = 40;
> }
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Code is correct. However, do you think it would be better to use
IGB_HKEY_MAX_INDEX and IXGBE_HKEY_MAX_INDEX in those driver assignments? I
realise the loops don't use them, but they probably should.
/Bruce
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/intel: update key_len when getting RSS key
2026-01-16 13:02 ` Bruce Richardson
@ 2026-01-16 13:11 ` Thierry Herbelot
0 siblings, 0 replies; 5+ messages in thread
From: Thierry Herbelot @ 2026-01-16 13:11 UTC (permalink / raw)
To: Bruce Richardson
Cc: dev, Thomas Monjalon, Anatoly Burakov, stable, Olivier Matz
On 1/16/26 14:02, Bruce Richardson wrote:
> On Mon, Jan 12, 2026 at 02:53:11PM +0100, Thierry Herbelot wrote:
>> When adding the i40e PMD, the rss_hash_conf_get function was changed to
>> update the RSS key len.
>> The corresponding functions for ixgbe & e1000 were not updated to
>> follow the new convention.
>>
>> Fixes: 8a387fa85f02 ("ethdev: more RSS flags")
>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>> ---
>> drivers/net/intel/e1000/igb_rxtx.c | 1 +
>> drivers/net/intel/e1000/igc_ethdev.c | 1 +
>> drivers/net/intel/ixgbe/ixgbe_rxtx.c | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/intel/e1000/igb_rxtx.c b/drivers/net/intel/e1000/igb_rxtx.c
>> index cdd7a3338f61..d5c2bc013702 100644
>> --- a/drivers/net/intel/e1000/igb_rxtx.c
>> +++ b/drivers/net/intel/e1000/igb_rxtx.c
>> @@ -2042,6 +2042,7 @@ int eth_igb_rss_hash_conf_get(struct rte_eth_dev *dev,
>> hash_key[(i * 4) + 2] = (rss_key >> 16) & 0x000000FF;
>> hash_key[(i * 4) + 3] = (rss_key >> 24) & 0x000000FF;
>> }
>> + rss_conf->rss_key_len = 40;
>> }
>>
>> /* Get RSS functions configured in MRQC register */
>> diff --git a/drivers/net/intel/e1000/igc_ethdev.c b/drivers/net/intel/e1000/igc_ethdev.c
>> index b9c91d2446c0..9f6ada3bc6cd 100644
>> --- a/drivers/net/intel/e1000/igc_ethdev.c
>> +++ b/drivers/net/intel/e1000/igc_ethdev.c
>> @@ -2559,6 +2559,7 @@ eth_igc_rss_hash_conf_get(struct rte_eth_dev *dev,
>> /* read RSS key from register */
>> for (i = 0; i < IGC_HKEY_MAX_INDEX; i++)
>> hash_key[i] = E1000_READ_REG_LE_VALUE(hw, E1000_RSSRK(i));
>> + rss_conf->rss_key_len = IGC_HKEY_MAX_INDEX * sizeof(uint32_t);
>> }
>>
>> /* get RSS functions configured in MRQC register */
>> diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
>> index a7583c178a14..a2c5ffe0b3b0 100644
>> --- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c
>> +++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
>> @@ -3756,6 +3756,7 @@ ixgbe_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
>> hash_key[(i * 4) + 2] = (rss_key >> 16) & 0x000000FF;
>> hash_key[(i * 4) + 3] = (rss_key >> 24) & 0x000000FF;
>> }
>> + rss_conf->rss_key_len = 40;
>> }
>>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Code is correct. However, do you think it would be better to use
> IGB_HKEY_MAX_INDEX and IXGBE_HKEY_MAX_INDEX in those driver assignments? I
> realise the loops don't use them, but they probably should.
Hello Bruce,
I will resend the patch, using the symbolic constants, as suggested.
Thanks
Thierry
>
> /Bruce
--
Thierry Herbelot
Senior Software Engineer
http://www.6wind.com/
Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware
^ permalink raw reply [flat|nested] 5+ messages in thread
* [V2] net/intel: update key_len when getting RSS key
2026-01-12 13:53 [PATCH] net/intel: update key_len when getting RSS key Thierry Herbelot
2026-01-16 13:02 ` Bruce Richardson
@ 2026-01-16 13:54 ` Thierry Herbelot
2026-01-16 14:12 ` Bruce Richardson
1 sibling, 1 reply; 5+ messages in thread
From: Thierry Herbelot @ 2026-01-16 13:54 UTC (permalink / raw)
To: dev
Cc: Thierry Herbelot, Thomas Monjalon, Bruce Richardson,
Anatoly Burakov, stable, Olivier Matz
When adding the i40e PMD, the rss_hash_conf_get function was changed
to update the RSS key len.
The corresponding functions for ixgbe & e1000 were not updated to
follow the new convention.
Fixes: 8a387fa85f02 ("ethdev: more RSS flags")
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
V2: For igb & ixgbe, a hard-coded integer is replaced a symbolic constant.
---
drivers/net/intel/e1000/igb_rxtx.c | 3 ++-
drivers/net/intel/e1000/igc_ethdev.c | 1 +
drivers/net/intel/ixgbe/ixgbe_rxtx.c | 3 ++-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/intel/e1000/igb_rxtx.c b/drivers/net/intel/e1000/igb_rxtx.c
index cdd7a3338f61..14b28588174f 100644
--- a/drivers/net/intel/e1000/igb_rxtx.c
+++ b/drivers/net/intel/e1000/igb_rxtx.c
@@ -2035,13 +2035,14 @@ int eth_igb_rss_hash_conf_get(struct rte_eth_dev *dev,
hash_key = rss_conf->rss_key;
if (hash_key != NULL) {
/* Return RSS hash key */
- for (i = 0; i < 10; i++) {
+ for (i = 0; i < IGB_HKEY_MAX_INDEX; i++) {
rss_key = E1000_READ_REG_ARRAY(hw, E1000_RSSRK(0), i);
hash_key[(i * 4)] = rss_key & 0x000000FF;
hash_key[(i * 4) + 1] = (rss_key >> 8) & 0x000000FF;
hash_key[(i * 4) + 2] = (rss_key >> 16) & 0x000000FF;
hash_key[(i * 4) + 3] = (rss_key >> 24) & 0x000000FF;
}
+ rss_conf->rss_key_len = IGB_HKEY_MAX_INDEX * sizeof(uint32_t);
}
/* Get RSS functions configured in MRQC register */
diff --git a/drivers/net/intel/e1000/igc_ethdev.c b/drivers/net/intel/e1000/igc_ethdev.c
index b9c91d2446c0..9f6ada3bc6cd 100644
--- a/drivers/net/intel/e1000/igc_ethdev.c
+++ b/drivers/net/intel/e1000/igc_ethdev.c
@@ -2559,6 +2559,7 @@ eth_igc_rss_hash_conf_get(struct rte_eth_dev *dev,
/* read RSS key from register */
for (i = 0; i < IGC_HKEY_MAX_INDEX; i++)
hash_key[i] = E1000_READ_REG_LE_VALUE(hw, E1000_RSSRK(i));
+ rss_conf->rss_key_len = IGC_HKEY_MAX_INDEX * sizeof(uint32_t);
}
/* get RSS functions configured in MRQC register */
diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
index a7583c178a14..e830bb9495b8 100644
--- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
@@ -3749,13 +3749,14 @@ ixgbe_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
hash_key = rss_conf->rss_key;
if (hash_key != NULL) {
/* Return RSS hash key */
- for (i = 0; i < 10; i++) {
+ for (i = 0; i < IXGBE_HKEY_MAX_INDEX; i++) {
rss_key = IXGBE_READ_REG_ARRAY(hw, rssrk_reg, i);
hash_key[(i * 4)] = rss_key & 0x000000FF;
hash_key[(i * 4) + 1] = (rss_key >> 8) & 0x000000FF;
hash_key[(i * 4) + 2] = (rss_key >> 16) & 0x000000FF;
hash_key[(i * 4) + 3] = (rss_key >> 24) & 0x000000FF;
}
+ rss_conf->rss_key_len = IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t);
}
if (!ixgbe_rss_enabled(hw)) { /* RSS is disabled */
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [V2] net/intel: update key_len when getting RSS key
2026-01-16 13:54 ` [V2] " Thierry Herbelot
@ 2026-01-16 14:12 ` Bruce Richardson
0 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2026-01-16 14:12 UTC (permalink / raw)
To: Thierry Herbelot
Cc: dev, Thomas Monjalon, Anatoly Burakov, stable, Olivier Matz
On Fri, Jan 16, 2026 at 02:54:35PM +0100, Thierry Herbelot wrote:
> When adding the i40e PMD, the rss_hash_conf_get function was changed
> to update the RSS key len.
> The corresponding functions for ixgbe & e1000 were not updated to
> follow the new convention.
>
> Fixes: 8a387fa85f02 ("ethdev: more RSS flags")
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
cc: stable@dpdk.org
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-01-16 14:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-12 13:53 [PATCH] net/intel: update key_len when getting RSS key Thierry Herbelot
2026-01-16 13:02 ` Bruce Richardson
2026-01-16 13:11 ` Thierry Herbelot
2026-01-16 13:54 ` [V2] " Thierry Herbelot
2026-01-16 14:12 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox