From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH 2/2] rte_sched: remove useless bitmap_free Date: Fri, 28 Aug 2015 09:49:59 -0700 Message-ID: <1440780599-14851-3-git-send-email-stephen@networkplumber.org> References: <1440780599-14851-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org To: cristian.dumitrescu@intel.com Return-path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id EA23E5A33 for ; Fri, 28 Aug 2015 18:49:52 +0200 (CEST) Received: by padfo6 with SMTP id fo6so29633975pad.0 for ; Fri, 28 Aug 2015 09:49:52 -0700 (PDT) In-Reply-To: <1440780599-14851-1-git-send-email-stephen@networkplumber.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity reports that rte_bitmap_free() does nothing and caller does not check return value. Just remove it. Also since rte_free(NULL) is a nop, remove useless check here. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_bitmap.h | 19 ------------------- lib/librte_sched/rte_sched.c | 5 ----- 2 files changed, 24 deletions(-) diff --git a/lib/librte_sched/rte_bitmap.h b/lib/librte_sched/rte_bitmap.h index 216a344..47eeeeb 100644 --- a/lib/librte_sched/rte_bitmap.h +++ b/lib/librte_sched/rte_bitmap.h @@ -275,25 +275,6 @@ rte_bitmap_init(uint32_t n_bits, uint8_t *mem, uint32_t mem_size) } /** - * Bitmap free - * - * @param bmp - * Handle to bitmap instance - * @return - * 0 upon success, error code otherwise - */ -static inline int -rte_bitmap_free(struct rte_bitmap *bmp) -{ - /* Check input arguments */ - if (bmp == NULL) { - return -1; - } - - return 0; -} - -/** * Bitmap reset * * @param bmp diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index 924c172..cbe3f3b 100644 --- a/lib/librte_sched/rte_sched.c +++ b/lib/librte_sched/rte_sched.c @@ -716,11 +716,6 @@ rte_sched_port_config(struct rte_sched_port_params *params) void rte_sched_port_free(struct rte_sched_port *port) { - /* Check user parameters */ - if (port == NULL) - return; - - rte_bitmap_free(port->bmp); rte_free(port); } -- 2.1.4