From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH 2/5] example_ip_pipeline: avoid strncpy issue Date: Mon, 31 Aug 2015 18:59:03 -0700 Message-ID: <1441072746-29174-3-git-send-email-stephen@networkplumber.org> References: <1441072746-29174-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org To: cristian.dumitrescu@intel.com Return-path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 704AC5A4B for ; Tue, 1 Sep 2015 03:58:59 +0200 (CEST) Received: by pabzx8 with SMTP id zx8so158046458pab.1 for ; Mon, 31 Aug 2015 18:58:58 -0700 (PDT) In-Reply-To: <1441072746-29174-1-git-send-email-stephen@networkplumber.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If name is so long that it fills buffer, then string would not be null terminated. Signed-off-by: Stephen Hemminger --- examples/ip_pipeline/config_parse_tm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/ip_pipeline/config_parse_tm.c b/examples/ip_pipeline/config_parse_tm.c index 84702b0..4a35715 100644 --- a/examples/ip_pipeline/config_parse_tm.c +++ b/examples/ip_pipeline/config_parse_tm.c @@ -354,7 +354,9 @@ tm_cfgfile_load_sched_subport( profile = atoi(entries[j].value); strncpy(name, entries[j].name, - sizeof(name)); + CFG_NAME_LEN - 1); + name[CFG_NAME_LEN-1] = '\0'; + n_tokens = rte_strsplit( &name[sizeof("pipe")], strnlen(name, CFG_NAME_LEN), -- 2.1.4