From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCHv4 1/5] ethdev: add new API to retrieve RX/TX queue information Date: Thu, 23 Jul 2015 18:17:25 +0200 Message-ID: <1441832.QYmNKRXLMA@xps13> References: <1437589735-30041-1-git-send-email-konstantin.ananyev@intel.com> <20150722124802.6a0f4745@urahara> <2601191342CEEE43887BDE71AB97725836A64BE0@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Ananyev, Konstantin" Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id A54FCC3AC for ; Thu, 23 Jul 2015 18:18:39 +0200 (CEST) Received: by wibud3 with SMTP id ud3so932555wib.0 for ; Thu, 23 Jul 2015 09:18:39 -0700 (PDT) In-Reply-To: <2601191342CEEE43887BDE71AB97725836A64BE0@irsmsx105.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-23 10:52, Ananyev, Konstantin: > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Konstantin Ananyev wrote: > > > Add the ability for the upper layer to query RX/TX queue information. [...] > > Since all this data should be rxconf already, Is it possible > > to do a generic version of this and not have to change every driver. > > I don't think it is possible to implement these two functions at rte_etdev level only. > At least not with current ethdev/PMD implementation: > - Inside struct rte_eth_dev_info we have only: 'struct rte_eth_rxconf default_rxconf;'. > We don't have rxconf here for each configured rx queue. > That information is maintained by PMD and inside PMD, different devices have different format for queue structure. > - rte_eth_rxq_info contains not only rxconf but some extra information: mempool in use by that queue, > min/max possible number of descriptors. > Also my intention was that in future that structure would be extended to provide some RT info about queue: > (number of free/used descriptors from SW point of view, etc). Isn't it what rte_eth_rx_queue_count() provides? Maybe we should deprecate it in favor of rte_eth_rx_queue_info_get().