From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] Pass verbose flag to kernel module
Date: Thu, 09 Oct 2014 14:15:40 +0200
Message-ID: <1443746.oWjnEGgJIl@xps13>
References: <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1731940.NUuDDJsRCL@xps13> <20141009093713.GB23978@sivswdev02.ir.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <20141009093713.GB23978-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Sergio,

2014-10-09 10:37, Sergio Gonzalez Monroy:
> On Wed, Oct 08, 2014 at 07:05:32PM +0200, Thomas Monjalon wrote:
> > Hi Sergio,
> > 
> > 2014-10-06 17:09, Sergio Gonzalez Monroy:
> > > --- a/mk/rte.module.mk
> > > +++ b/mk/rte.module.mk
> > > @@ -78,7 +78,7 @@ build: _postbuild
> > >  $(MODULE).ko: $(SRCS_LINKS)
> > >  	@if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
> > >  	@$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
> > > -		CROSS_COMPILE=$(CROSS)
> > > +		V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS)
> > 
> > Please could you explain why it is needed?
> > The variable V should be inherited by the recursive make.
> > It's working without your patch in my test.
> 
> You are right. If you set V=1 in the commmand line it will inherit and pass it down.
> In the curent framework, we do not force V to be 1, just to be defined (coud be V=y
> or V=enable, etc).
> This patch was just forcing the value to be 1 as it is the required value for the
> kernel makefiles.
> 
> It is not a big deal and we could approach this by specifiying on the docs to be V=1
> or any other way you think more appropiate?

Oh OK, I didn't imagine passing other value to V ;)
It's better to fix makefile than doc. So I'm OK with this patch.

-- 
Thomas