From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Charles (Chas) Williams" <3chas3@gmail.com> Subject: Re: [PATCH v2] devargs: add blacklisting by linux interface name Date: Tue, 06 Oct 2015 10:41:46 -0400 Message-ID: <1444142506.3494.55.camel@gmail.com> References: <1443798007-20122-1-git-send-email-3chas3@gmail.com> <1444058768-9208-1-git-send-email-3chas3@gmail.com> <20151006083555.72293697@uryu.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Stephen Hemminger Return-path: Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id CAE685921 for ; Tue, 6 Oct 2015 16:41:47 +0200 (CEST) Received: by qkht68 with SMTP id t68so2254654qkh.3 for ; Tue, 06 Oct 2015 07:41:47 -0700 (PDT) In-Reply-To: <20151006083555.72293697@uryu.home.lan> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 2015-10-06 at 08:35 +0100, Stephen Hemminger wrote: > On Mon, 5 Oct 2015 11:26:08 -0400 > Chas Williams <3chas3@gmail.com> wrote: > > > diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h > > index 83e3c28..852c149 100644 > > --- a/lib/librte_eal/common/include/rte_pci.h > > +++ b/lib/librte_eal/common/include/rte_pci.h > > @@ -161,6 +161,7 @@ struct rte_pci_device { > > struct rte_pci_resource mem_resource[PCI_MAX_RESOURCE]; /**< PCI Memory Resource */ > > struct rte_intr_handle intr_handle; /**< Interrupt handle */ > > struct rte_pci_driver *driver; /**< Associated driver */ > > + char name[32]; > > Why not use IFNAMSIZ rather than magic constant here? No particular reason. It just matches the virtual device name size. I will change it.