From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Shearer Subject: [PATCH] lib/librte_ether: Prevent link status race condition when LSI enabled Date: Tue, 27 Oct 2015 17:38:55 -0400 Message-ID: <1445981935-3559-1-git-send-email-tim.shearer@overturenetworks.com> References: <5406727.UN0rhZ0d4I@xps13> Cc: Tim Shearer To: dev@dpdk.org Return-path: Received: from localhost.localdomain (unknown [50.58.84.238]) by dpdk.org (Postfix) with ESMTP id B0BEC5A64 for ; Tue, 27 Oct 2015 22:39:37 +0100 (CET) In-Reply-To: <5406727.UN0rhZ0d4I@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Calling the Ethernet driver's link_update function from rte_eth_dev_start can result in a race condition if the NIC raises the link interrupt at the same time. Depending on the interrupt handler implementation, the race can cause the it to think that it received two consecutive link up interrupts, and it exits without calling the user callback. Appears to impact E1000/IGB and virtio drivers only. Signed-off-by: Tim Shearer --- lib/librte_ether/rte_ethdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index f593f6e..a821a1f 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -1300,7 +1300,7 @@ rte_eth_dev_start(uint8_t port_id) rte_eth_dev_config_restore(port_id); - if (dev->data->dev_conf.intr_conf.lsc != 0) { + if (dev->data->dev_conf.intr_conf.lsc == 0) { FUNC_PTR_OR_ERR_RET(*dev->dev_ops->link_update, -ENOTSUP); (*dev->dev_ops->link_update)(dev, 0); } -- 1.7.2.3