From mboxrd@z Thu Jan 1 00:00:00 1970 From: Na Na Subject: [PATCH v3 2/2] lib/lpm:fix incorrect reuse of already allocated tbl8 Date: Tue, 3 Nov 2015 10:17:41 +0800 Message-ID: <1446517061-19261-3-git-send-email-nana.nn@alibaba-inc.com> References: <1446517061-19261-1-git-send-email-nana.nn@alibaba-inc.com> To: dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 95CA38E98 for ; Tue, 3 Nov 2015 03:17:52 +0100 (CET) In-Reply-To: <1446517061-19261-1-git-send-email-nana.nn@alibaba-inc.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes an initialization issue of 'valid_group' in the delete_depth_small(). When adding an entry to a tbl8, the .valid_group field should always be set, so that future adds do not accidently find and use this table, thinking it is currently invalid, i.e. unused, and thereby overwrite existing entries. Signed-off-by: Na Na --- lib/librte_lpm/rte_lpm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c index 57ec2f0..3981452 100644 --- a/lib/librte_lpm/rte_lpm.c +++ b/lib/librte_lpm/rte_lpm.c @@ -769,6 +769,7 @@ delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked, struct rte_lpm_tbl8_entry new_tbl8_entry = { .valid = VALID, + .valid_group = VALID, .depth = sub_rule_depth, .next_hop = lpm->rules_tbl [sub_rule_index].next_hop, -- 1.7.7.6