From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: [PATCH v2 1/2] ethdev: rework value return by rte_eth_dev_is_detachable Date: Tue, 3 Nov 2015 12:34:59 +0100 Message-ID: <1446550500-24029-2-git-send-email-david.marchand@6wind.com> References: <1446108903-14412-1-git-send-email-david.marchand@6wind.com> <1446550500-24029-1-git-send-email-david.marchand@6wind.com> To: dev@dpdk.org Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id B95348E8B for ; Tue, 3 Nov 2015 12:35:24 +0100 (CET) Received: by wmeg8 with SMTP id g8so82001571wme.0 for ; Tue, 03 Nov 2015 03:35:24 -0800 (PST) In-Reply-To: <1446550500-24029-1-git-send-email-david.marchand@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Maxime Leroy The rte_eth_dev_is_detachable return 0 when the device is detachable. It not, this one return a negative value or 1. Such behavior is not logical. This patch modifies this function to return 1 when the device is detachable and 0 when is not. Signed-off-by: Maxime Leroy Signed-off-by: David Marchand --- lib/librte_ether/rte_ethdev.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 073ffe9..ec1b632 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -510,7 +510,7 @@ rte_eth_dev_is_detachable(uint8_t port_id) if (!rte_eth_dev_is_valid_port(port_id)) { PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); - return -EINVAL; + return 0; } if (rte_eth_devices[port_id].dev_type == RTE_ETH_DEV_PCI) { @@ -521,12 +521,12 @@ rte_eth_dev_is_detachable(uint8_t port_id) break; case RTE_KDRV_VFIO: default: - return -ENOTSUP; + return 0; } } drv_flags = rte_eth_devices[port_id].driver->pci_drv.drv_flags; - return !(drv_flags & RTE_PCI_DRV_DETACHABLE); + return drv_flags & RTE_PCI_DRV_DETACHABLE; } /* attach the new physical device, then store port_id of the device */ @@ -574,7 +574,7 @@ rte_eth_dev_detach_pdev(uint8_t port_id, struct rte_pci_addr *addr) goto err; /* check whether the driver supports detach feature, or not */ - if (rte_eth_dev_is_detachable(port_id)) + if (!rte_eth_dev_is_detachable(port_id)) goto err; /* get pci address by port id */ @@ -651,7 +651,7 @@ rte_eth_dev_detach_vdev(uint8_t port_id, char *vdevname) goto err; /* check whether the driver supports detach feature, or not */ - if (rte_eth_dev_is_detachable(port_id)) + if (!rte_eth_dev_is_detachable(port_id)) goto err; /* get device name by port id */ -- 1.9.1