From mboxrd@z Thu Jan 1 00:00:00 1970 From: John McNamara Subject: [PATCH v2] ring: fix minor memory free issue Date: Fri, 6 Nov 2015 17:40:39 +0000 Message-ID: <1446831639-9576-1-git-send-email-john.mcnamara@intel.com> References: <1446830917-7376-1-git-send-email-john.mcnamara@intel.com> Cc: dev@dpdk.org To: bruce.richardson@intel.com Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4F0518D95 for ; Fri, 6 Nov 2015 18:40:44 +0100 (CET) In-Reply-To: <1446830917-7376-1-git-send-email-john.mcnamara@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix minor memory free issue in error clean-up. Fixes: 651c505af862 ("ring: enhance device setup from rings") Reported-by Coverity (CID 119258) Signed-off-by: John McNamara --- V2: * Add fixline. drivers/net/ring/rte_eth_ring.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index cc60008..b91a643 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -363,9 +363,11 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[], return data->port_id; error: - rte_free(data->rx_queues); - rte_free(data->tx_queues); - rte_free(data); + if (data) { + rte_free(data->rx_queues); + rte_free(data->tx_queues); + rte_free(data); + } rte_free(internals); return -1; -- 1.8.1.4