From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: [PATCH 01/14] mlx4: fix possible crash when clearing device statistics Date: Mon, 23 Nov 2015 15:44:36 +0100 Message-ID: <1448289889-9590-2-git-send-email-adrien.mazarguil@6wind.com> References: <1448289889-9590-1-git-send-email-adrien.mazarguil@6wind.com> To: dev@dpdk.org Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 47E4A8E95 for ; Mon, 23 Nov 2015 15:45:17 +0100 (CET) Received: by wmuu63 with SMTP id u63so57111142wmu.0 for ; Mon, 23 Nov 2015 06:45:17 -0800 (PST) Received: from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id t5sm13466884wmt.1.2015.11.23.06.45.15 for (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Nov 2015 06:45:16 -0800 (PST) In-Reply-To: <1448289889-9590-1-git-send-email-adrien.mazarguil@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A typo causes TX stats indices to be retrieved from RX queues. Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") Reported-by: Nicolas Harnois Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index 4198c04..d961a8a 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -3958,7 +3958,7 @@ mlx4_stats_reset(struct rte_eth_dev *dev) for (i = 0; (i != priv->txqs_n); ++i) { if ((*priv->txqs)[i] == NULL) continue; - idx = (*priv->rxqs)[i]->stats.idx; + idx = (*priv->txqs)[i]->stats.idx; (*priv->txqs)[i]->stats = (struct mlx4_txq_stats){ .idx = idx }; } -- 2.1.0