From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] l3fwd-acl: fix possible memory leak. Date: Wed, 17 Dec 2014 01:12:53 +0100 Message-ID: <1448328.g5Olc06rYm@xps13> References: <1418749508-17748-1-git-send-email-konstantin.ananyev@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Konstantin Ananyev Return-path: In-Reply-To: <1418749508-17748-1-git-send-email-konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > At error app_acl_init() can return without freeing dynamically allocated memory. > Not really a big problem, as if app_acl_init() fails, > then application would terminate immediately anyway. > Though it is a good coding practise to make a function to cleanup after itself. > > Signed-off-by: Konstantin Ananyev Applied Thanks -- Thomas