From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH] virtio: fix link state regression
Date: Thu,  3 Dec 2015 18:08:24 -0800
Message-ID: <1449194904-9626-1-git-send-email-stephen@networkplumber.org>
Cc: dev@dpdk.org
To: huawei.xie@intel.com, yuanhan.liu@linux.intel.com,
 bernard.iremonger@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com
 [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id 1A8DB568A
 for <dev@dpdk.org>; Fri,  4 Dec 2015 03:08:18 +0100 (CET)
Received: by pacdm15 with SMTP id dm15so78550756pac.3
 for <dev@dpdk.org>; Thu, 03 Dec 2015 18:08:17 -0800 (PST)
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Support for link state interrupt was broken on virtio by

commit bda66c418c85 ("ethdev: add device fields from PCI layer")

This is caused because the actual value of drv_flags is not set
until after the resource_init has figured out whether it is using
UIO or direct I/O instructions.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
There maybe other drivers with the same problem. It would have
been better to move the structure elements (and break ABI) rather
than assume it safe to copy them. Better to fail compiling.