From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH resend] virtio: fix link state regression Date: Fri, 4 Dec 2015 07:59:26 -0800 Message-ID: <1449244766-29031-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org To: huawei.xie@intel.com, yuanhan.liu@linux.intel.com, bernard.iremonger@intel.com Return-path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by dpdk.org (Postfix) with ESMTP id 913588E90 for ; Fri, 4 Dec 2015 16:59:18 +0100 (CET) Received: by pacdm15 with SMTP id dm15so88676525pac.3 for ; Fri, 04 Dec 2015 07:59:18 -0800 (PST) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Support for link state interrupt was broken on virtio by commit bda66c418c85 ("ethdev: add device fields from PCI layer") This is caused because the actual value of drv_flags is not set until after the resource_init has figured out whether it is using UIO or direct I/O instructions. Signed-off-by: Stephen Hemminger --- There maybe other drivers with the same problem. It would have been better to move the structure elements (and break ABI) rather than assume it safe to copy them. drivers/net/virtio/virtio_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 74c00ee..8e12804 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1289,11 +1289,11 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev) pci_dev = eth_dev->pci_dev; - rte_eth_copy_pci_info(eth_dev, pci_dev); - if (virtio_resource_init(pci_dev) < 0) return -1; + rte_eth_copy_pci_info(eth_dev, pci_dev); + hw->use_msix = virtio_has_msix(&pci_dev->addr); hw->io_base = (uint32_t)(uintptr_t)pci_dev->mem_resource[0].addr; -- 2.1.4