From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: [PATCH] virtio: fix wrong queue index for VIRTIO_PCI_QUEUE_SEL Date: Tue, 8 Dec 2015 11:05:12 +0800 Message-ID: <1449543912-31066-1-git-send-email-yuanhan.liu@linux.intel.com> To: dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 875F41396 for ; Tue, 8 Dec 2015 04:04:17 +0100 (CET) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" We should provide VIRTIO_PCI_QUEUE_SEL with vq->vq_queue_idx, but not vq->queue_id. vq->queue_id is the queue id from rte_eth_rx/tx_queue_setup(), which always starts from 0 no matter which queue it is. However, for virtio, even number is for RX queue, and odd number is for TX queue. Fixes: 5382b188fb8a ("virtio: add queue release") Cc: Bernard Iremonger Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 16ff827..d928339 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -273,7 +273,7 @@ virtio_dev_queue_release(struct virtqueue *vq) { if (vq) { hw = vq->hw; /* Select and deactivate the queue */ - VIRTIO_WRITE_REG_2(hw, VIRTIO_PCI_QUEUE_SEL, vq->queue_id); + VIRTIO_WRITE_REG_2(hw, VIRTIO_PCI_QUEUE_SEL, vq->vq_queue_index); VIRTIO_WRITE_REG_4(hw, VIRTIO_PCI_QUEUE_PFN, 0); rte_free(vq->sw_ring); -- 1.9.0