From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo de Lara Subject: [PATCH v4] Fixes following error on gcc 4.4.7: Date: Wed, 9 Dec 2015 12:20:30 +0000 Message-ID: <1449663630-83289-1-git-send-email-pablo.de.lara.guarch@intel.com> References: <1449659374-78252-1-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable To: dev@dpdk.org Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2C7D8569C for ; Wed, 9 Dec 2015 13:20:36 +0100 (CET) In-Reply-To: <1449659374-78252-1-git-send-email-pablo.de.lara.guarch@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" make: Entering directory `/tmp/dpdk-tmp/examples/vhost' CC main.o cc1: warnings being treated as errors /tmp/dpdk-tmp/examples/vhost/main.c: In function =E2=80=98new_device=E2=80= =99: /tmp/dpdk-tmp/x86_64-native-linuxapp-gcc/include/rte_ring.h:740: error: dereferencing pointer =E2=80=98mbuf.486=E2=80=99 does break strict-al= iasing rules /tmp/dpdk-tmp/examples/vhost/main.c:1503: note: initialized from here ... /tmp/dpdk-tmp/examples/vhost/main.c:1503: note: initialized from here /tmp/dpdk-tmp/x86_64-native-linuxapp-gcc/include/rte_ring.h:740: error: dereferencing pointer =E2=80=98({anonymous})=E2=80=99 does break stri= ct-aliasing rules /tmp/dpdk-tmp/examples/vhost/main.c:1804: note: initialized from here make[1]: *** [main.o] Error 1 Fixes: d19533e8 ("examples/vhost: copy old vhost example") Reported-by: Qian Xu Signed-off-by: Pablo de Lara --- Changes in v4: - Simplify patch, just casting to void *, without using new variables Changes in v3: - Remove even more unnecessary castings Changes in v2: - Remove unnecessary casting examples/vhost/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index dc3a012..f3c50c5 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/main.c @@ -1500,7 +1500,7 @@ attach_rxmbuf_zcp(struct virtio_net *dev) } } while (unlikely(phys_addr =3D=3D 0)); =20 - rte_ring_sc_dequeue(vpool->ring, (void **)&mbuf); + rte_ring_sc_dequeue(vpool->ring, (void *)mbuf); if (unlikely(mbuf =3D=3D NULL)) { LOG_DEBUG(VHOST_DATA, "(%"PRIu64") in attach_rxmbuf_zcp: " @@ -1801,7 +1801,7 @@ virtio_tx_route_zcp(struct virtio_net *dev, struct = rte_mbuf *m, =20 /* Allocate an mbuf and populate the structure. */ vpool =3D &vpool_array[MAX_QUEUES + vmdq_rx_q]; - rte_ring_sc_dequeue(vpool->ring, (void **)&mbuf); + rte_ring_sc_dequeue(vpool->ring, (void *)mbuf); if (unlikely(mbuf =3D=3D NULL)) { struct vhost_virtqueue *vq =3D dev->virtqueue[VIRTIO_TXQ]; RTE_LOG(ERR, VHOST_DATA, --=20 2.5.0