From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasesh Mody Subject: [PATCH v4 2/9] bnx2x: Fix x86_64-native-linuxapp-clang build error Date: Thu, 10 Dec 2015 22:36:35 -0800 Message-ID: <1449815802-1131-3-git-send-email-rasesh.mody@qlogic.com> References: <1449815802-1131-1-git-send-email-rasesh.mody@qlogic.com> Mime-Version: 1.0 Content-Type: text/plain Cc: sony.chacko@qlogic.com To: , Return-path: Received: from mx0b-0016ce01.pphosted.com (mx0b-0016ce01.pphosted.com [67.231.156.153]) by dpdk.org (Postfix) with ESMTP id ADC7A8E86 for ; Fri, 11 Dec 2015 07:37:08 +0100 (CET) In-Reply-To: <1449815802-1131-1-git-send-email-rasesh.mody@qlogic.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Harish Patil Fix for the following clang build error: drivers/net/bnx2x/elink.c:10384:41: error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value] vars->eee_status &= ~SHMEM_EEE_1G_ADV << ~~~~~~~~~~~~~~~~~ ^ 1 error generated. make[6]: *** [elink.o] Error 1 make[5]: *** [bnx2x] Error 2 make[4]: *** [net] Error 2 make[3]: *** [drivers] Error 2 make[2]: *** [all] Error 2 make[1]: *** [x86_64-native-linuxapp-clang_install] Error 2 make: *** [install] Error 2 Signed-off-by: Harish Patil --- drivers/net/bnx2x/ecore_hsi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/ecore_hsi.h b/drivers/net/bnx2x/ecore_hsi.h index 6c11c5a..d2cb888 100644 --- a/drivers/net/bnx2x/ecore_hsi.h +++ b/drivers/net/bnx2x/ecore_hsi.h @@ -2529,7 +2529,7 @@ struct shmem2_region { #define SHMEM_EEE_SUPPORTED_SHIFT 16 #define SHMEM_EEE_ADV_STATUS_MASK 0x00f00000 #define SHMEM_EEE_100M_ADV (1<<0) - #define SHMEM_EEE_1G_ADV (1<<1) + #define SHMEM_EEE_1G_ADV (1U<<1) #define SHMEM_EEE_10G_ADV (1<<2) #define SHMEM_EEE_ADV_STATUS_SHIFT 20 #define SHMEM_EEE_LP_ADV_STATUS_MASK 0x0f000000 -- 1.7.10.3