From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 07/41] bus/dpaa: enable DPAA IOCTL portal
	driver
Date: Mon, 18 Sep 2017 15:51:32 +0100
Message-ID: <144b891a-5457-5a3e-5c0d-33ef02cccc07@intel.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-8-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: hemant.agrawal@nxp.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 169831AEEB
 for <dev@dpdk.org>; Mon, 18 Sep 2017 16:51:44 +0200 (CEST)
In-Reply-To: <20170909112132.13936-8-shreyansh.jain@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/9/2017 12:20 PM, Shreyansh Jain wrote:
> Userspace applications interact with DPAA blocks using this IOCTL driver.
> 
> Signed-off-by: Geoff Thorpe <geoff.thorpe@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

<...>

> +static int fd = -1;
> +static pthread_mutex_t fd_init_lock = PTHREAD_MUTEX_INITIALIZER;
> +
> +static int check_fd(void)
> +{
> +	int ret;
> +
> +	if (fd >= 0)
> +		return 0;
> +	ret = pthread_mutex_lock(&fd_init_lock);

Do you need to link against pthred library for this":
LDLIBS += -lpthread

<...>

> +/* The process device underlies process-wide user/kernel interactions, such as
> + * mapping dma_mem memory and providing accompanying ioctl()s. (This isn't used
> + * for portals, which use one UIO device each.).
> + */
> +#define PROCESS_PATH		"/dev/fsl-usdpaa"

Who is creating this file, who is responsible to responding ioctl()
calls, there must a kernel module, right?

<...>