From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] doc: update user guide about e1000em
	limitations
Date: Mon, 14 Dec 2015 00:07:48 +0100
Message-ID: <1450058419.bBIceI6b3P@xps13>
References: <1446196988-3634-1-git-send-email-yong.liu@intel.com>
 <B27915DBBA3421428155699D51E4CFE2023BBA92@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Liu, Yong" <yong.liu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id A6A5158CF
 for <dev@dpdk.org>; Mon, 14 Dec 2015 00:09:04 +0100 (CET)
Received: by mail-wm0-f47.google.com with SMTP id p66so39376648wmp.1
 for <dev@dpdk.org>; Sun, 13 Dec 2015 15:09:04 -0800 (PST)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023BBA92@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > Update interrupt related limitations for e1000em nic.
> > It only support one interrupt source and not support auto-clear.
> > 
> > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> > 
> > diff --git a/doc/guides/nics/e1000em.rst b/doc/guides/nics/e1000em.rst
> > index fedafad..a84e8e1 100644
> > --- a/doc/guides/nics/e1000em.rst
> > +++ b/doc/guides/nics/e1000em.rst
> > @@ -176,3 +176,7 @@ The following are known limitations:
> >      testpmd [options] -- --mbuf-size=<your-max-packet-size>
> > 
> >  #.  Qemu e1000 does not validate the checksum of incoming packets.
> > +
> > +#.  Qemu e1000 only support one interrupt source, so link and Rx
> > interrupt should be exclusive.
> > +
> > +#.  Qemu e1000 does not support interrupt auto-clear, application should
> > disable interrupt immediately when waked up.
> 
> Hi Marvin,
> 
> Thanks for the clarification. Two minor typos:
> 
>     Qemu e1000 only supports one interrupt source ...
> 
>     ... disable interrupt immediately when woken up.
> 
> When changes are made:
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied with changes, thanks