From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shukla Subject: [ [PATCH v2] 13/13] virtio_ethdev : fix format specifier error for 64bit addr case Date: Mon, 14 Dec 2015 18:30:32 +0530 Message-ID: <1450098032-21198-14-git-send-email-sshukla@mvista.com> References: <1450098032-21198-1-git-send-email-sshukla@mvista.com> Cc: Rakesh Krishnamurhty To: dev@dpdk.org Return-path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 3D5028E93 for ; Mon, 14 Dec 2015 14:01:24 +0100 (CET) Received: by pabur14 with SMTP id ur14so103996782pab.0 for ; Mon, 14 Dec 2015 05:01:23 -0800 (PST) In-Reply-To: <1450098032-21198-1-git-send-email-sshukla@mvista.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" fix format specifier for func virtio_resource_init_by_ioports. %04hx-%04hx couldn't read 64bit address correctly that lead to wrong value in %mem_resource[0].addr / len; result in testpmd failure. For example, so to read this address 00001040-0000105f; default format-specifier could read 0-0 that lead to below error on arm64/ThunderX Unhandled fault: alignment fault (0x92000021) at 0x0000007fb5040002 Signed-off-by: Santosh Shukla Signed-off-by: Rakesh Krishnamurhty --- drivers/net/virtio/virtio_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 017d49f..8107aef 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1169,7 +1169,7 @@ static int virtio_resource_init_by_ioports(struct rte_pci_device *pci_dev) while (*ptr && isspace(*ptr)) ptr++; - sscanf(ptr, "%04hx-%04hx", &start, &end); + sscanf(ptr, "%hx-%hx", &start, &end); size = end - start + 1; break; -- 1.7.9.5