From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jingjing Wu Subject: [PATCH] i40e: fix unintended sign extension Date: Wed, 16 Dec 2015 00:23:07 +0800 Message-ID: <1450196587-23248-1-git-send-email-jingjing.wu@intel.com> To: dev@dpdk.org Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 025B93B5 for ; Tue, 15 Dec 2015 17:23:16 +0100 (CET) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity issue reported like CID 119268 (#1 of 1): Unintended sign extension (SIGN_EXTENSION)sign_extension: Suspicious implicit sign extension: vsi_id with type unsigned short (16 bits, unsigned) is promoted in vsi_id << 23 to type int (32 bits, signed), then sign-extended to type unsigned long (64 bits, unsigned). If vsi_id << 23 is greater than 0x7FFFFFFF, the upper bits of the result will all be 1. Fixes: 88ebc2b7f976 ("i40e: extend flow director to support VF") Signed-off-by: Jingjing Wu --- drivers/net/i40e/i40e_fdir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 43a39ec..9ad6981 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -1091,7 +1091,7 @@ i40e_fdir_filter_programming(struct i40e_pf *pf, /* Use LAN VSI Id by default */ vsi_id = pf->main_vsi->vsi_id; fdirdp->qindex_flex_ptype_vsi |= - rte_cpu_to_le_32((vsi_id << + rte_cpu_to_le_32(((uint32_t)vsi_id << I40E_TXD_FLTR_QW0_DEST_VSI_SHIFT) & I40E_TXD_FLTR_QW0_DEST_VSI_MASK); -- 2.4.0