From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 3/5] i40e: support selecting hash functions Date: Thu, 24 Jul 2014 10:07:37 +0200 Message-ID: <1454201.eyrodsIZYi@xps13> References: <1406184149-11531-1-git-send-email-helin.zhang@intel.com> <9589603.4uh6CsY5aa@xps13> <20140724080113.GB21277@mhcomputing.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Matthew Hall , Helin Zhang Return-path: In-Reply-To: <20140724080113.GB21277-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-07-24 01:01, Matthew Hall: > On Thu, Jul 24, 2014 at 09:59:23AM +0200, Thomas Monjalon wrote: > > Is it really a good idea to configure this kind of thing at build time? > > Maybe yes, I'm not sure. > > Whether it's safe to set at runtime probably depends what happens to the card > if it gets changed. Do you have to reset the card or the port? Or is it OK if > it's more dynamic? No, we can change configuration with rte_eth_dev_configure() before initializing port. So it is truly configurable. Requiring recompilation means it's not really configurable between 2 runs. And it breaks binary packaging for Linux distributions. Many things in DPDK are configured at build time. But we should wonder if it's really a good design. -- Thomas