From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH v2 0/5] clean-up cpuflags Date: Sat, 6 Feb 2016 23:17:08 +0100 Message-ID: <1454797033-24057-1-git-send-email-thomas.monjalon@6wind.com> References: <1454453993-3903-1-git-send-email-thomas.monjalon@6wind.com> Cc: dev@dpdk.org, viktorin@rehivetech.com To: david.marchand@6wind.com, ferruh.yigit@intel.com Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 6C74E5946 for ; Sat, 6 Feb 2016 23:18:36 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id 128so112320118wmz.1 for ; Sat, 06 Feb 2016 14:18:36 -0800 (PST) In-Reply-To: <1454453993-3903-1-git-send-email-thomas.monjalon@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Following the work of Ferruh, I suggest this cleanup to remove as much as possible of the code from the cpuflags headers. The goal is to un-inline these functions (not performance sensitive) and remove the CPU flags table from the ABI (just added recently). The bonus is to stop mimic x86 in ARM and PPC implementations. WARNING: it has not been tested nor compiled on Tilera and POWER8. v2 changes: - fix maintainers file - fix include from C++ app - fix missing REG_PLATFORM for ARM - suggested ARM refactor from Jerin Thomas Monjalon (5): eal: get CPU flag name eal: move CPU flag functions out of headers eal/arm: adapt CPU flags check to the arch eal/ppc: adapt CPU flags check to the arch eal: remove compiler optimization workaround MAINTAINERS | 4 + app/test/test_hash_scaling.c | 2 + lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 +- lib/librte_eal/common/arch/arm/rte_cpuflags.c | 179 ++++++++++++++++----- lib/librte_eal/common/arch/ppc_64/rte_cpuflags.c | 145 +++++++++++++---- lib/librte_eal/common/arch/tile/rte_cpuflags.c | 11 ++ lib/librte_eal/common/arch/x86/rte_cpuflags.c | 91 +++++++++++ lib/librte_eal/common/eal_common_cpuflags.c | 18 +-- .../common/include/arch/arm/rte_cpuflags_32.h | 80 +-------- .../common/include/arch/arm/rte_cpuflags_64.h | 81 +--------- .../common/include/arch/ppc_64/rte_cpuflags.h | 66 +------- .../common/include/arch/tile/rte_cpuflags.h | 31 +--- .../common/include/arch/x86/rte_cpuflags.h | 68 +------- .../common/include/generic/rte_cpuflags.h | 56 ++----- lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 +- 15 files changed, 378 insertions(+), 458 deletions(-) -- 2.7.0