From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: [PATCH] scripts: fix checkpatch help Date: Tue, 16 Feb 2016 15:36:54 +0100 Message-ID: <1455633414-4778-1-git-send-email-olivier.matz@6wind.com> To: dev@dpdk.org Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id C0B03C166 for ; Tue, 16 Feb 2016 15:37:14 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id a4so103127587wme.1 for ; Tue, 16 Feb 2016 06:37:14 -0800 (PST) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When started without defining DPDK_CHECKPATCH_PATH, the usage was not displayed. Signed-off-by: Olivier Matz --- scripts/checkpatches.sh | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/scripts/checkpatches.sh b/scripts/checkpatches.sh index afc611b..1e765e3 100755 --- a/scripts/checkpatches.sh +++ b/scripts/checkpatches.sh @@ -34,10 +34,6 @@ # - DPDK_CHECKPATCH_PATH # - DPDK_CHECKPATCH_LINE_LENGTH . scripts/load-devel-config.sh -if [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then - echo 'Cannot execute DPDK_CHECKPATCH_PATH' >&2 - exit 1 -fi length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} @@ -51,7 +47,12 @@ SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ NEW_TYPEDEFS,COMPARISON_TO_NULL" print_usage () { - echo "usage: $(basename $0) [-q] [-v] [patch1 [patch2] ...]]" + cat <<- END_OF_HELP + usage: $(basename $0) [-q] [-v] [patch1 [patch2] ...]] + + Run Linux kernel checkpatch.pl with DPDK options. + The environment variable DPDK_CHECKPATCH_PATH must be set. + END_OF_HELP } quiet=false @@ -66,6 +67,13 @@ while getopts hqv ARG ; do done shift $(($OPTIND - 1)) +if [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then + print_usage + echo + echo 'Cannot execute DPDK_CHECKPATCH_PATH' >&2 + exit 1 +fi + status=0 for p in "$@" ; do ! $verbose || printf '\n### %s\n\n' "$p" -- 2.1.4