From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH] vmxnet3: remove asserts that confuse coverity Date: Wed, 30 Mar 2016 14:38:25 -0700 Message-ID: <1459373905-10296-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org, Stephen Hemminger To: Yong Wang Return-path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 2D89C2C61 for ; Wed, 30 Mar 2016 23:38:12 +0200 (CEST) Received: by mail-pa0-f42.google.com with SMTP id zm5so49995139pac.0 for ; Wed, 30 Mar 2016 14:38:12 -0700 (PDT) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" These asserts are only for debugging and never fired during any testing, but they confuse coverity's null tracking. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 66b0eed..f72156a 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -710,7 +710,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) * the last mbuf of the current packet. */ if (rcd->sop) { - VMXNET3_ASSERT(rxq->start_seg != NULL); VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_HEAD); if (unlikely(rcd->len == 0)) { @@ -729,7 +728,6 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) struct rte_mbuf *start = rxq->start_seg; VMXNET3_ASSERT(rxd->btype == VMXNET3_RXD_BTYPE_BODY); - VMXNET3_ASSERT(start != NULL); start->pkt_len += rxm->data_len; start->nb_segs++; -- 2.1.4