From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mrzyglod Subject: [PATCH] eal: fix resource leak Date: Mon, 11 Apr 2016 11:46:54 +0200 Message-ID: <1460368014-9012-1-git-send-email-danielx.t.mrzyglod@intel.com> Cc: anatoly.burakov@intel.com To: dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 658DA4A63 for ; Mon, 11 Apr 2016 11:47:21 +0200 (CEST) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" CID 13289 (#1-2 of 2): Resource leak (RESOURCE_LEAK): The system resource will not be reclaimed and reused, reducing the future availability of the resource. In pci_vfio_get_group_fd: Leak of memory or pointers to system resources Fixes: ff0b67d1c868 ("vfio: DMA mapping") Signed-off-by: Daniel Mrzyglod --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c index fdfdeb4..10266f8 100644 --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c @@ -535,6 +535,7 @@ pci_vfio_get_group_fd(int iommu_group_no) /* if the fd is valid, create a new group for it */ if (vfio_cfg.vfio_group_idx == VFIO_MAX_GROUPS) { RTE_LOG(ERR, EAL, "Maximum number of VFIO groups reached!\n"); + close(vfio_group_fd); return -1; } vfio_cfg.vfio_groups[vfio_cfg.vfio_group_idx].group_no = iommu_group_no; -- 2.5.5