From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: [RFC PATCH v2 0/3] Remove string operations from xstats Date: Fri, 6 May 2016 12:11:11 +0100 Message-ID: <1462533074-1994-1-git-send-email-remy.horton@intel.com> References: <1460731462-21229-1-git-send-email-remy.horton@intel.com> To: dev@dpdk.org Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6B8F82C4B for ; Fri, 6 May 2016 13:11:17 +0200 (CEST) In-Reply-To: <1460731462-21229-1-git-send-email-remy.horton@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The current extended ethernet statistics fetching involve doing several string operations, which causes performance issues if there are lots of statistics and/or network interfaces. This RFC patchset changes the API for xstats to use integer identifiers instead of strings and implements this new API for the ixgbe driver. Others drivers to follow. -- v2 changes: * Fetching xstats count now seperate API function * Added #define constants for some magic numbers * Fixed bug with virtual function count fetching * For non-xstats-supporting drivers, queue stats returned * Some refactoring/cleanups * Removed index assumption from example Remy Horton (3): rte: change xstats to use integer keys drivers/net/ixgbe: change xstats to use integer keys examples/ethtool: add xstats display command drivers/net/ixgbe/ixgbe_ethdev.c | 98 ++++++++++++++++++++++++++++----- examples/ethtool/ethtool-app/ethapp.c | 57 +++++++++++++++++++ lib/librte_ether/rte_ethdev.c | 100 +++++++++++++++++++++++++++++----- lib/librte_ether/rte_ethdev.h | 55 +++++++++++++++++++ 4 files changed, 284 insertions(+), 26 deletions(-) -- 2.5.5