From mboxrd@z Thu Jan 1 00:00:00 1970 From: zr@semihalf.com Subject: [PATCH v2 2/2] examples/ethtool: get reg width to allocate memory Date: Mon, 30 May 2016 11:40:10 +0200 Message-ID: <1464601210-7372-2-git-send-email-zr@semihalf.com> References: <1464601210-7372-1-git-send-email-zr@semihalf.com> Cc: dev@dpdk.org, Zyta Szpak To: remy.horton@intel.com, thomas.monjalon@6wind.com Return-path: Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com [209.85.217.172]) by dpdk.org (Postfix) with ESMTP id 124C468F8 for ; Mon, 30 May 2016 11:40:17 +0200 (CEST) Received: by mail-lb0-f172.google.com with SMTP id sh2so43850813lbb.1 for ; Mon, 30 May 2016 02:40:17 -0700 (PDT) In-Reply-To: <1464601210-7372-1-git-send-email-zr@semihalf.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Zyta Szpak Version 2 of fixing the fixed register width assumption. Not every device uses 32-bit wide register. The app was allocating too little space for 64-bit registers which resulted in memory corruption. This commit resolves this by getting the size of register in bytes for a specific device. If the device does not implement this function, it fallsback to sizeof(uint32_t) Signed-off-by: Zyta Szpak --- examples/ethtool/lib/rte_ethtool.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c index 42e05f1..59191ca 100644 --- a/examples/ethtool/lib/rte_ethtool.c +++ b/examples/ethtool/lib/rte_ethtool.c @@ -88,10 +88,14 @@ int rte_ethtool_get_regs_len(uint8_t port_id) { int count_regs; + int reg_width; count_regs = rte_eth_dev_get_reg_length(port_id); + reg_width = rte_eth_dev_get_reg_width(port_id); + if (reg_width < 0) + reg_width = sizeof(uint32_t); if (count_regs > 0) - return count_regs * sizeof(uint32_t); + return count_regs * reg_width; return count_regs; } -- 1.9.1