From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: [PATCH] kni: fix use of undefined comma variable in makefile Date: Mon, 30 May 2016 13:56:46 +0200 Message-ID: <1464609406-23152-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: thomas.monjalon@6wind.com, helin.zhang@intel.com To: dev@dpdk.org Return-path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 541665958 for ; Mon, 30 May 2016 13:56:52 +0200 (CEST) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The $(comma) variable is not defined in this Makefile, nor in any included Makefile. Seen while doing a "make clean" on ubuntu: $ make clean =3D=3D Clean lib =3D=3D Clean lib/librte_compat =3D=3D Clean lib/librte_eal =3D=3D Clean lib/librte_eal/common =3D=3D Clean lib/librte_eal/linuxapp =3D=3D Clean lib/librte_eal/linuxapp/eal =3D=3D Clean lib/librte_eal/linuxapp/igb_uio =3D=3D Clean lib/librte_eal/linuxapp/kni tr: missing operand after =E2=80=98.-=E2=80=99 Two strings must be given when translating. Try 'tr --help' for more information. This commit replaces $(comma) by a ',' character, it's not a problem in that case since we are inside antiquotes. Fixes: a09b359daca3 ("kni: fix build on Ubuntu 14.04") Signed-off-by: Olivier Matz --- lib/librte_eal/linuxapp/kni/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/kni/Makefile b/lib/librte_eal/linuxa= pp/kni/Makefile index ac99d3f..8cc6b61 100644 --- a/lib/librte_eal/linuxapp/kni/Makefile +++ b/lib/librte_eal/linuxapp/kni/Makefile @@ -47,7 +47,7 @@ MODULE_CFLAGS +=3D -Wall -Werror ifeq ($(shell lsb_release -si 2>/dev/null),Ubuntu) MODULE_CFLAGS +=3D -DUBUNTU_RELEASE_CODE=3D$(shell lsb_release -sr | tr = -d .) UBUNTU_KERNEL_CODE :=3D $(shell echo `grep UTS_RELEASE $(RTE_KERNELDIR)/= include/generated/utsrelease.h \ - | cut -d '"' -f2 | cut -d- -f1,2 | tr .- $(comma)`,1) + | cut -d '"' -f2 | cut -d- -f1,2 | tr .- ,`,1) MODULE_CFLAGS +=3D -D"UBUNTU_KERNEL_CODE=3DUBUNTU_KERNEL_VERSION($(UBUNT= U_KERNEL_CODE))" endif =20 --=20 2.8.0.rc3