From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jasvinder Singh Subject: [PATCH] librte_sched: fix compile error on unused parameter red Date: Thu, 2 Jun 2016 11:28:10 +0100 Message-ID: <1464863290-216968-1-git-send-email-jasvinder.singh@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cristian.dumitrescu@intel.com To: dev@dpdk.org Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 95CAD2BDD for ; Thu, 2 Jun 2016 12:22:03 +0200 (CEST) List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit fixes the following compile error messages when CONFIG_RTE_SCHED_RED=3Dn and CONFIG_RTE_SCHED_COLLECT_STATS=3Dy; rte_sched.c: In function =E2=80=98rte_sched_port_update_subport_stats_on_= drop=E2=80=99: rte_sched.c:1090:41: error: unused parameter =E2=80=98red=E2=80=99 [-Werr= or=3Dunused-parameter] struct rte_mbuf *pkt, uint32_t red) ^ rte_sched.c: In function =E2=80=98rte_sched_port_update_queue_stats_on_dr= op=E2=80=99: rte_sched.c:1116:39: error: unused parameter =E2=80=98red=E2=80=99 [-Werr= or=3Dunused-parameter] struct rte_mbuf *pkt, uint32_t red) Fixes: 4d51afb5cdb6 ("sched: keep track of RED drops") Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- lib/librte_sched/rte_sched.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index 1609ea8..8696423 100644 --- a/lib/librte_sched/rte_sched.c +++ b/lib/librte_sched/rte_sched.c @@ -1084,10 +1084,17 @@ rte_sched_port_update_subport_stats(struct rte_sc= hed_port *port, uint32_t qindex s->stats.n_bytes_tc[tc_index] +=3D pkt_len; } =20 +#ifdef RTE_SCHED_RED static inline void rte_sched_port_update_subport_stats_on_drop(struct rte_sched_port *port, - uint32_t qindex, - struct rte_mbuf *pkt, uint32_t red) + uint32_t qindex, + struct rte_mbuf *pkt, uint32_t red) +#else +static inline void +rte_sched_port_update_subport_stats_on_drop(struct rte_sched_port *port, + uint32_t qindex, + struct rte_mbuf *pkt, __rte_unused uint32_t red) +#endif { struct rte_sched_subport *s =3D port->subport + (qindex / rte_sched_por= t_queues_per_subport(port)); uint32_t tc_index =3D (qindex >> 2) & 0x3; @@ -1110,10 +1117,17 @@ rte_sched_port_update_queue_stats(struct rte_sche= d_port *port, uint32_t qindex, qe->stats.n_bytes +=3D pkt_len; } =20 +#ifdef RTE_SCHED_RED static inline void rte_sched_port_update_queue_stats_on_drop(struct rte_sched_port *port, - uint32_t qindex, - struct rte_mbuf *pkt, uint32_t red) + uint32_t qindex, + struct rte_mbuf *pkt, uint32_t red) +#else +static inline void +rte_sched_port_update_queue_stats_on_drop(struct rte_sched_port *port, + uint32_t qindex, + struct rte_mbuf *pkt, __rte_unused uint32_t red) +#endif { struct rte_sched_queue_extra *qe =3D port->queue_extra + qindex; uint32_t pkt_len =3D pkt->pkt_len; --=20 2.5.5